Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMonad.Prelude incompatible with ghc 9.8's base #826

Closed
3 tasks done
geekosaur opened this issue Aug 28, 2023 · 2 comments · Fixed by #829
Closed
3 tasks done

XMonad.Prelude incompatible with ghc 9.8's base #826

geekosaur opened this issue Aug 28, 2023 · 2 comments · Fixed by #829

Comments

@geekosaur
Copy link
Contributor

Problem Description

XMonad.Prelude needs revision for the base that ships with ghc 9.8.

[ 31 of 312] Compiling XMonad.Prelude   ( XMonad/Prelude.hs, dist/build/XMonad/Prelude.o, dist/build/XMonad/Prelude.dyn_o )

XMonad/Prelude.hs:18:5: error: [GHC-69158]
    Conflicting exports for ‘unzip’:
       ‘module Exports’ exports ‘Exports.unzip’
         imported from ‘Data.Functor’ at XMonad/Prelude.hs:50:1-37
       ‘module Exports’ exports ‘Exports.unzip’
         imported from ‘Data.List’ at XMonad/Prelude.hs:51:1-37
         (and originally defined in ‘GHC.List’)
   |
18 |     module Exports,
   |     ^^^^^^^^^^^^^^

XMonad/Prelude.hs:22:5: error: [GHC-87543]
    Ambiguous occurrence ‘!?’.
    It could refer to
       either ‘Exports.!?’,
              imported from ‘Data.List’ at XMonad/Prelude.hs:51:1-37
              (and originally defined in ‘GHC.List’),
           or ‘XMonad.Prelude.!?’, defined at XMonad/Prelude.hs:84:1.
   |
22 |     (!?),
   |     ^^^^

Steps to Reproduce

Try to build xmonad-contrib with the ghc 9.8 prerelease.

Checklist

  • I've read CONTRIBUTING.md

  • I tested my configuration

    • With xmonad version 0.17.2.9 (commit 5c2ba06 if using git)
    • With xmonad-contrib version 0.17.1.9 (commit 2df26cf if using git)
@geekosaur
Copy link
Contributor Author

We may also want to disable -Wx-partial which complains about head and tail among other things throughout the codebase.

@slotThe
Copy link
Member

slotThe commented Aug 29, 2023

XMonad.Prelude needs revision for the base that ships with ghc 9.8.

Mh, I guess some CPP it necessary here :/

We may also want to disable -Wx-partial which complains about head and tail among other things throughout the codebase.

A more ambitious goal would be to fix all of these occurences, of course :)

slotThe added a commit to slotThe/xmonad-contrib that referenced this issue Sep 17, 2023
slotThe added a commit to slotThe/xmonad-contrib that referenced this issue Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants