Rewrite minimization-related modules #102

f1u77y · 2016-10-25T04:22:31Z

Use global state instead of per-layout - so now window is minimized on
all workspaces (EWMH requires that windows with _NET_WM_STATE_HIDDEN
set should be minimized on any workspace but previously they were not)
Use windows instead of modify. That should fix bugs related to
actions that should be done by windows and not done by
modify (fixes multiple windows are highlighted as active when using X.L.Minimize #46)
Deprecated module X.H.RestoreMinimized is removed

~~TODO 515429f should be moved to another PR~~

UPD TODO entry in CHANGES.md

byorgey · 2016-11-03T21:44:18Z

I think another PR containing something similar to @515429ff has now been merged, so this now has a conflict.

colonelpanic8 · 2016-11-10T21:59:34Z

What's the status of this PR?

colonelpanic8 · 2016-11-29T22:29:37Z

@byorgey
Is there anything blocking a merge here?

f1u77y · 2016-11-29T22:31:39Z

@IvanMalison this PR should leave the old behaviour as is(as geekosaur said), so yes

colonelpanic8 · 2016-12-26T01:23:15Z

@f1u77y are you planning to make the changes needed to get this merged?

This should get merged before .13 right?

pjones · 2017-02-07T01:10:34Z

@f1u77y What is the status of this PR? It looks like it no longer contains any conflicts.

The only problem I see is that this PR deletes X.H.RestoreMinimized. I think we should actually add some {-# DEPRECATED #-} pragmas first, before we git rid of it.

f1u77y · 2017-02-12T07:48:32Z

@pjones ok, I've restored that module but it was marked as deprecated(in docs) in 2010. Isn't it enough?

…

On 02/07/2017 04:10 AM, Peter J. Jones wrote: @f1u77y <https://github.com/f1u77y> What is the status of this PR? It looks like it no longer contains any conflicts. The only problem I see is that this PR deletes |X.H.RestoreMinimized|. I think we should actually add some |{-# DEPRECATED #-}| pragmas first, before we git rid of it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#102 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKyf5WyV8TOwCCHsJoRh0g-VRgF8L0YWks5rZ8SLgaJpZM4KfjE_>.

-- Bogdan Sinitsyn

geekosaur · 2017-02-12T08:00:54Z

How many people read docs, especially after they have something working? The pragma means they get a warning every time they recompile their config.

colonelpanic8 · 2017-02-21T21:07:12Z

IS there anything blocking merge here?

pjones · 2017-02-21T21:18:46Z

Someone needs to review the code and test it with their config. So it's just a matter of when a core team member having the time to do so. This issue is part of the v0.14 milestone which I'm hoping will be released in Q2 of this year.

pjones · 2017-04-10T19:35:32Z

@f1u77y Please add an entry to CHANGES.md so we can get this merged. Thanks.

colonelpanic8 · 2017-04-14T22:42:55Z

I'd be happy to add to the CHANGES.md.

Lets get this merged

colonelpanic8 · 2017-04-14T22:54:12Z

Add Changes.MD here https://github.com/IvanMalison/xmonad-contrib/tree/rewrite-minimize
f1u77y#3

pjones · 2017-04-14T23:21:34Z

@f1u77y Can you merge in the changes from @IvanMalison, and then rebase and squash commits? Thanks.

colonelpanic8 · 2017-04-17T23:08:20Z

@f1u77y This still needs a squash

colonelpanic8 · 2017-04-17T23:10:14Z

@pjones Actually, because of the way the merges were done (I realize that this is against the contributing guidelines) a squash would be somewhat difficult. It would be possible to go back and cherry-pick all of the relevant commits on top of the current HEAD of contrib if you would prefer that. I think it might be better to just leave the history as is.

f1u77y · 2017-04-20T15:29:47Z

@pjones @IvanMalison I've squashed the commits. This is the old version of the branch. I hope I haven't missed something. At least that works well on my config.

Sorry for the delay.

pjones · 2017-04-20T15:40:43Z

@f1u77y Awesome! Thanks for doing that.

Last question. Since I don't use this module, what can users expect upon upgrade? Will their configuration files still compile and work?

f1u77y · 2017-04-20T16:09:42Z

No, because old configuration uses sending messages to layout and new one uses functions instead. I think the docs are descriptive enough to let user migrate easily.

EDIT Another way is leave old modules as is and rename the new modules, so users won't be left with non-working configs but I think it's a little messy.

pjones · 2017-04-20T16:46:25Z

I think it's okay to break things. But, please add an entry to the change log in the "breaking changes" section that makes it clear that config files need to be updated after the upgrade. Thanks.

f1u77y · 2017-04-20T17:02:08Z

@pjones done. If there are no other questions I'll squash it.

* Use global state instead of per-layout - so now window is minimized on all workspaces (EWMH requires that windows with _NET_WM_STATE_HIDDEN set should be minimized on any workspace but previously they were not) * Use `windows` instead of `modify`. That should fix bugs related to actions that should be done by `windows` and not done by `modify` (fixes xmonad#46) * Mark module X.H.RestoreMinimized as deprecated

pjones · 2017-04-20T17:16:49Z

Looks good. After you squash please rebase on master. The bit in the change log about the manage hook was removed in a recent commit.

f1u77y · 2017-04-20T17:32:21Z

I don't understand what bit are you talking about(is it c99606b#diff-8b1c3fd0d4a6765c16dfd18509182f9dL78 ?). This branch is up-to-date with upstream/master, so rebasing has no effect.

pjones · 2017-04-20T17:46:23Z

I'm talking about the "ewmh function from X.H.EwmhDesktops" text in CHANGES.md. It must have not been removed when I reverted another commit earlier. I'll take care of it.

Thanks for all the work on this.

This was referenced Oct 25, 2016

Redraw border when minimizing and restoring window #49

Closed

Rewrite X.U.NamedScratchpad using X.L.Minimize #90

Closed

f1u77y force-pushed the rewrite-minimize branch 2 times, most recently from 377e459 to 8965811 Compare October 25, 2016 04:32

f1u77y force-pushed the rewrite-minimize branch 2 times, most recently from 22f72f7 to d4f4f0d Compare November 3, 2016 21:51

pjones added the needs refactor label Dec 8, 2016

pjones added enhancement and removed needs refactor labels Feb 7, 2017

pjones modified the milestones: v0.13, v0.14 Feb 7, 2017

f1u77y force-pushed the rewrite-minimize branch 2 times, most recently from 2036556 to c70759b Compare February 12, 2017 07:23

pjones added 6.topic: actions labels Apr 10, 2017

pjones mentioned this pull request Apr 10, 2017

multiple windows are highlighted as active when using X.L.Minimize #46

Closed

pjones added 9.needs: review labels Apr 14, 2017

f1u77y force-pushed the rewrite-minimize branch from 3f66747 to 0920e51 Compare April 20, 2017 15:25

pjones removed 9.needs: review labels Apr 20, 2017

f1u77y force-pushed the rewrite-minimize branch from 2b6e1c5 to c99606b Compare April 20, 2017 17:27

pjones merged commit 7e47ecc into xmonad:master Apr 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewrite minimization-related modules #102

Rewrite minimization-related modules #102

f1u77y commented Oct 25, 2016 •

edited

Loading

byorgey commented Nov 3, 2016

colonelpanic8 commented Nov 10, 2016

colonelpanic8 commented Nov 29, 2016

f1u77y commented Nov 29, 2016

colonelpanic8 commented Dec 26, 2016

pjones commented Feb 7, 2017

f1u77y commented Feb 12, 2017 via email

geekosaur commented Feb 12, 2017

colonelpanic8 commented Feb 21, 2017

pjones commented Feb 21, 2017

pjones commented Apr 10, 2017

colonelpanic8 commented Apr 14, 2017

colonelpanic8 commented Apr 14, 2017 •

edited

Loading

pjones commented Apr 14, 2017

colonelpanic8 commented Apr 17, 2017

colonelpanic8 commented Apr 17, 2017 •

edited

Loading

f1u77y commented Apr 20, 2017

pjones commented Apr 20, 2017

f1u77y commented Apr 20, 2017 •

edited

Loading

pjones commented Apr 20, 2017

f1u77y commented Apr 20, 2017

pjones commented Apr 20, 2017

f1u77y commented Apr 20, 2017 •

edited

Loading

pjones commented Apr 20, 2017

Rewrite minimization-related modules #102

Rewrite minimization-related modules #102

Conversation

f1u77y commented Oct 25, 2016 • edited Loading

byorgey commented Nov 3, 2016

colonelpanic8 commented Nov 10, 2016

colonelpanic8 commented Nov 29, 2016

f1u77y commented Nov 29, 2016

colonelpanic8 commented Dec 26, 2016

pjones commented Feb 7, 2017

f1u77y commented Feb 12, 2017 via email

geekosaur commented Feb 12, 2017

colonelpanic8 commented Feb 21, 2017

pjones commented Feb 21, 2017

pjones commented Apr 10, 2017

colonelpanic8 commented Apr 14, 2017

colonelpanic8 commented Apr 14, 2017 • edited Loading

pjones commented Apr 14, 2017

colonelpanic8 commented Apr 17, 2017

colonelpanic8 commented Apr 17, 2017 • edited Loading

f1u77y commented Apr 20, 2017

pjones commented Apr 20, 2017

f1u77y commented Apr 20, 2017 • edited Loading

pjones commented Apr 20, 2017

f1u77y commented Apr 20, 2017

pjones commented Apr 20, 2017

f1u77y commented Apr 20, 2017 • edited Loading

pjones commented Apr 20, 2017

f1u77y commented Oct 25, 2016 •

edited

Loading

colonelpanic8 commented Apr 14, 2017 •

edited

Loading

colonelpanic8 commented Apr 17, 2017 •

edited

Loading

f1u77y commented Apr 20, 2017 •

edited

Loading

f1u77y commented Apr 20, 2017 •

edited

Loading