Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle workspace by screen #167

Merged
merged 1 commit into from
Apr 21, 2017

Conversation

colonelpanic8
Copy link
Contributor

Cycle through previously viewed workspaces in the order they were viewed most
recently on the screen where cycling is taking place.

The extremely long name is needed to differentiate this module from XMonad.Actions.CycleRecentWS which does something quite similar, with the main difference being that the history for different screens is not indendent (though it has the advantage of not depending on workspacse history)

I also provided the repeatableAction and update WorkspaceHistory as part of this change.

@mention-bot
Copy link

@IvanMalison, thanks for your PR! By analyzing the history of the files in this pull request, we identified @spencerjanssen, @bogner and @gwern to be potential reviewers.

@pjones
Copy link
Contributor

pjones commented Apr 14, 2017

@IvanMalison Two things:

  1. Please squash your commits. See this file for more details.

  2. What's going on with all the changes in the .cabal file?

@colonelpanic8
Copy link
Contributor Author

colonelpanic8 commented Apr 15, 2017

Please squash your commits. See this file for more details.

Sure. Do you want me to put everything from History and CycleRecent together or can I keep those separate.

What's going on with all the changes in the .cabal file?

I just ran M-x sort lines on all the modules since they are clearly SUPPOSED to be alphabetically sorted. It seems like a few mistakes were made here and there. I'll change it back but doesn't it seem better to just have it be correctly sorted?

@pjones
Copy link
Contributor

pjones commented Apr 15, 2017

Go ahead and squash everything into a single commit. And thanks for the note about sorting. That makes sense.

@colonelpanic8 colonelpanic8 force-pushed the CycleWorkspaceByScreen branch 2 times, most recently from 2524890 to 3c8a0f9 Compare April 17, 2017 21:19
@colonelpanic8
Copy link
Contributor Author

@pjones Merge?

@pjones pjones merged commit e5534d1 into xmonad:master Apr 21, 2017
@pjones
Copy link
Contributor

pjones commented Apr 21, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants