X.H.ManageDocks: React to strut updates of override_redirect docks #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Mar 23, 2021
| @@ -121,8 +123,11 @@ remove :: (ExtensionClass a, XLike m) => a -> m () | |||
| remove wit = modifyStateExts $ M.delete (show . typeOf $ wit) | |||
|
|
|||
| modified :: (ExtensionClass a, Eq a, XLike m) => (a -> a) -> m Bool | |||
| modified f = do | |||
| modified = modifiedM . (pure .) | |||
There was a problem hiding this comment.
Arguably this refactor should be a separate PR.
There was a problem hiding this comment.
I can definitely turn this into a commit on its own but a separate PR seems excessive.
There was a problem hiding this comment.
Other than that (and a similar feeling about the
deleteFromStru[c]tCachecorrection), this seems okay.
I split both into separate commits.
Fixes: c48d81e ("Fix caching issues in ManageDocks")
This is primarily a cleanup to make it easier to use `setDocksMask` from the on-demand cache init (see further commits), but it makes the code nicer: - the logic to refresh and cache a strut is now concentrated in `updateStrut` instead of being spread over `updateStrutCache` and `docksEventHook` - the logic to initialize the cache if not yet initialized is now concentrated in `maybeInitStrutCache` instead of being spread over `initStrutCache` and `getStrutCache`, so the dual-purpose return type of `getStrutCache` is no more - the logic to detect changes and refresh is now always handled by `XS.modifiedM` instead of an additional `||` Related: xmonad#406
We only requested PropertyChange events from docks in the `manageDocks` manageHook, but that only gets called for normal windows, not override_redirect ones. Therefore, xmobar in its default configuration wouldn't get its struts refreshed on changes. This resulted in gaps not updating after xmobar repositions itself on xrandr changes. If one wanted to handle that repositioning in xmonad, it was possible to configure xmobar with `overrideRedirect = False`, which is meant for window managers with proper EWMH stacking order support [1], so in xmonad it resulted in xmobar covering fullscreen windows. That can be worked around by adding `checkDock --> doLower` to manageHook, but it starts to smell of too many workarounds. [1]: https://specifications.freedesktop.org/wm-spec/wm-spec-1.5.html#STACKINGORDER The fix is to request PropertyChange events for all windows that we treat as docks. Related: xmonad#490
liskin
force-pushed
the
pr/managedocks-override-redirect
branch
from
81f4bd2
to
ec14617
Compare
This was referenced Mar 27, 2021
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We only requested PropertyChange events from docks in the
manageDocksmanageHook, but that only gets called for normal windows, not override_redirect ones. Therefore, xmobar in its default configuration wouldn't get its struts refreshed on changes. This resulted in gaps not updating after xmobar repositions itself on xrandr changes.If one wanted to handle that repositioning in xmonad, it was possible to configure xmobar with
overrideRedirect = False, which is meant for window managers with proper EWMH stacking order support, so in xmonad it resulted in xmobar covering fullscreen windows. That can be worked around by addingcheckDock --> doLowerto manageHook, but it starts to smell of too many workarounds.The fix is to request PropertyChange events for all windows that we treat as docks.
Related: #406
Related: #490
Checklist
I've read CONTRIBUTING.md
I tested my changes with xmonad-testing
I updated the
CHANGES.mdfilen/a I updated the
XMonad.Doc.Extendingfile (if appropriate)