Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: XMonad.Hooks.OnPropertyChange #770

Merged
merged 1 commit into from Oct 29, 2022

Conversation

slotThe
Copy link
Member

@slotThe slotThe commented Oct 28, 2022

I'm not married to either of these names; suggestions welcome.

Description

This is the same module as X.H.DynamicProperty, just with (hopefully)
more discoverable names.

Closes: #588

Checklist

  • I've read CONTRIBUTING.md

  • I've considered how to best test these changes (property, unit,
    manually, ...) and concluded: The deprecations show up correctly.

  • I updated the CHANGES.md file

Copy link
Contributor

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@liskin liskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit dropping most of the code and just reexporting the new module instead. Feel free to drop it if it ends up breaking something.

@geekosaur
Copy link
Contributor

I admit I'd been wondering about that; I should have commented.

This is the same module as X.H.DynamicProperty, just with (hopefully)
more discoverable names.

Closes: xmonad#588

Co-authored-by: Tomas Janousek <tomi@nomi.cz>
@slotThe slotThe merged commit c27a1f0 into xmonad:master Oct 29, 2022
@slotThe slotThe deleted the bikeshed/dynamicproperty branch October 29, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ManageHooks don't work well for applications that set their WM Class late in their startup process
3 participants