Revise XDG handling #258
Merged
Revise XDG handling #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slotThe
force-pushed
the
xdg-things
branch
2 times, most recently
from
9fdadaa
to
6baf36c
Compare
slotThe
force-pushed
the
xdg-things
branch
5 times, most recently
from
e8f44bb
to
9caade1
Compare
|
@geekosaur @liskin @psibi what do you people think? I think the abstract approach mentioned in #256 is sound and this implementation "works for me" and shouldn't break any existing configs |
psibi
reviewed
Jan 5, 2021
psibi
approved these changes
Jan 5, 2021
3 tasks
slotThe
force-pushed
the
xdg-things
branch
3 times, most recently
from
3de1064
to
41066ad
Compare
liskin
requested changes
Jan 7, 2021
slotThe
force-pushed
the
xdg-things
branch
3 times, most recently
from
7383a3d
to
0d9c56b
Compare
Improve handling of the whole XDG situation. This now looks as follows
1. If all three of xmonad's environment variables (XMONAD_DATA_DIR,
XMONAD_CONFIG_DIR, and XMONAD_CACHE_DIR) are set, use them.
2. If there is a build script `build' or configuration `xmonad.hs' in
`~/.xmonad', set all three directories to `~/.xmonad'.
3. Otherwise, use XDG_DATA_HOME, XDG_CONFIG_HOME, and
XDG_CACHE_HOME (or their respective fallbacks).
If none of the above exist, we default to using the XDG_* variables,
creating the necessary directories if needed.
liskin
approved these changes
Jan 7, 2021
| -- command will add it to the GHC include path. | ||
| -- | ||
| -- * @cacheDir@: This directory is used to store temporary files that | ||
| -- can easily be recreated. For example, the XPrompt history file. |
There was a problem hiding this comment.
It's a bit funny that the configuration binary, which can be easily recreated, gets placed in dataDir, whereas the prompt history, which requires superhuman memory abilities or superhuman backup regime to recreate, goes in cacheDir. But xmonad isn't the only program that does it this way so I guess it doesn't matter.
This was referenced Jan 8, 2021
Closed
Closed
liskin
added a commit
to xmonad/xmonad-contrib
that referenced
this pull request
Jun 2, 2021
With the bumped xmonad dependency, we can drop these, leaving just 4 warnings visible in ghcid. \o/ Related: xmonad/xmonad#258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #164 and #256
I'm putting this out here in a relatively early state, because I know
opinions are to be had on a lot of these things, so I'd rather not wait
until this is more mature for people to say I've done something horribly
wrong.
As per #256, this puts forth the following changes to how we handle the
whole config situation.
XMONAD_DATA_DIR,XMONAD_CONFIG_DIR, andXMONAD_CACHE_DIR) are set, use them.buildor configurationxmonad.hsin~/.xmonad, set all three directories to~/.xmonad.XDG_DATA_HOME,XDG_CONFIG_HOME, andXDG_CACHE_HOME(or their respective fallbacks).If none of the above exist, we default to using the XDG_* variables,
creating the necessary directories if needed.
In the cases of 1. and 3., the build script or executable is expected to
be in the config dir (this is the case at the moment as well).
This doesn't quite compile with
xmonad-contribyet, though therearen't very many changes needed to make it work. I've created a quick
fix on this branch, in case anyone wants to try this. From my (very) light
testing so far, it at least seems to do what it's supposed to.
Checklist
I've read CONTRIBUTING.md
I've confirmed these changes don't belong in xmonad-contrib instead
I tested my changes with xmonad-testing
I updated the
CHANGES.mdfile