Encoding fix for auth in python3 for issue #52 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanr
reviewed
Dec 27, 2021
xmpp/auth.py
Outdated
| @@ -37,10 +37,12 @@ def H(some): | |||
| if IS_PYTHON3 and isinstance(some, str): | |||
| some = some.encode("utf-8") | |||
| return md5(some).digest() | |||
|
|
|||
There was a problem hiding this comment.
Keep the whitespace consistent between HH&H and H&C (either both have whitespace, or neither have whitespace).
Bonus points for removing the print("HH:some:", some) from HH, that looks like left over debugging from #45.
There was a problem hiding this comment.
Hi. I've just addressed this with e6f4667.
|
Dear Sumit and Norman, both thanks for this contribution and for the bump. With kind regards, |
amotl
approved these changes
Dec 27, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.