Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineReader: fix partial read #1893

Merged
merged 1 commit into from Oct 14, 2020
Merged

LineReader: fix partial read #1893

merged 1 commit into from Oct 14, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 13, 2020

No description provided.

@xmrig
Copy link
Owner

xmrig commented Oct 13, 2020

Can you please provide test case for the fix.
Thank you.

@xmrig xmrig added this to the v6 milestone Oct 13, 2020
@ghost
Copy link
Author

ghost commented Oct 13, 2020

xmrig stdout
[2020-10-13 18:01:49.960] [127.0.0.1:18888] received (61 bytes): "{"method":"ping","params":[]}                                "
[2020-10-13 18:01:49.961] [127.0.0.1:18888] received (61 bytes): "{"method":"ping","params":[]}                                "
[2020-10-13 18:01:49.963] [127.0.0.1:18888] received (61 bytes): "{"method":"ping","params":[]}                                "
[2020-10-13 18:01:49.965] [127.0.0.1:18888] received (123 bytes): "{"method"
[2020-10-13 18:01:49.965]  net      127.0.0.1:18888 JSON decode failed: "Missing a closing quotation mark in string."
sent packets
sent:  b'{"method":"ping","params":[]}                                \n'
sent:  b'{"method":"ping","params":[]}                                \n'
sent:  b'{"method":"ping","params":[]}                                '
sent:  b'\n{"method":"ping","params":[]} '
sent:  b'                               \n'
fixed xmrig stdout
[2020-10-13 18:09:44.986] [127.0.0.1:18888] received (61 bytes): "{"method":"ping","params":[]}                                "
[2020-10-13 18:09:44.987] [127.0.0.1:18888] received (61 bytes): "{"method":"ping","params":[]}                                "
[2020-10-13 18:09:44.990] [127.0.0.1:18888] received (61 bytes): "{"method":"ping","params":[]}                                "
[2020-10-13 18:09:44.991] [127.0.0.1:18888] received (61 bytes): "{"method":"ping","params":[]}                                "

@xmrig xmrig added the bug label Oct 14, 2020
@xmrig xmrig merged commit 677d287 into xmrig:dev Oct 14, 2020
@xmrig
Copy link
Owner

xmrig commented Oct 14, 2020

Thank you.

@ghost ghost deleted the fix_partial_read branch October 14, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant