Add legacy V2 identity key association #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardhuaaa
force-pushed
the
rich/add-legacy-association
branch
from
8bab3b6
to
5b0e803
Compare
5 tasks
richardhuaaa
added a commit
to xmtp/libxmtp
that referenced
this pull request
Sep 26, 2023
…nstallation key (#230) An association proves that a given XMTP installation key is acting on behalf of a given blockchain account address, typically using a signature of some kind. There can be multiple different types of associations, one of which is an [EIP191 association](https://eips.ethereum.org/EIPS/eip-191). I'm adding [another association type](xmtp/proto#97) shortly. We haven't settled on consistent terminology until recently. To avoid confusion, this renames: - Association.addr -> Association.blockchain_address - Association.account_public_key -> Association.installation_public_key - Association -> Eip191Association Also fix some lints/unused imports. **Note: This PR will break any existing databases used by the CLI. Please re-register any installations after this lands.**
neekolas
reviewed
Sep 28, 2023
| // Legacy - all of the information needed to construct the Create Identity | ||
| // association text used in XMTP v2 | ||
| message CreateIdentityAssociationData { | ||
| string wallet_address = 1; |
There was a problem hiding this comment.
This is confusing to me, since the Create Identity association text is actually the encoded protobuf of the public key, not the wallet address.
neekolas
reviewed
Sep 28, 2023
| // EIP191Association is used for all EIP 191 compliant wallet signatures | ||
| message Eip191Association { | ||
| AssociationTextVersion association_text_version = 1; | ||
| reserved 1; |
There was a problem hiding this comment.
Do we care about reserving fields if we aren't yet worried about interoperability between existing versions. Think we can just throw away all our existing v3 keys and start fresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to test out v3 in current SDK's without introducing breaking changes. Publishing now to avoid conflict with Daria's ramp-up task.