Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SendOptions work more like the JS SDK #45

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Make SendOptions work more like the JS SDK #45

merged 3 commits into from
Jan 23, 2023

Conversation

nakajima
Copy link
Contributor

This brings sending behavior more in line with what the JS SDK does. Also some README updates for things that were out of date.

@nakajima nakajima marked this pull request as ready for review January 21, 2023 21:43
@nakajima nakajima requested a review from a team January 21, 2023 21:43
nplasterer
nplasterer approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm going to have to change some things I've done in Kotlin.

@nakajima nakajima merged commit 9f0f769 into main Jan 23, 2023
@nakajima nakajima deleted the cleanups branch January 23, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nakajima @nplasterer