Rewrite ABSi64 to avoid a Visual Studio warning.

- negating unsigned integers is one of the few well defined operations in C...
xnd-project · Jan 8, 2018 · 9423906 · 9423906
1 parent da8caef
commit 9423906
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/libndtypes/overflow.h b/libndtypes/overflow.h
@@ -66,9 +66,11 @@ MULi64(int64_t a, int64_t b, bool *overflow)
 static inline int64_t
 ABSi64(int64_t a, bool *overflow)
 {
-    int64_t b = a >= 0 ? a : (int64_t)(-((uint64_t)a));
-    *overflow |= a == INT64_MIN;
-    return b;
+    if (a == INT64_MIN) {
+        *overflow = 1;
+        return INT64_MIN;
+    }
+    return a >= 0 ? a : -a;
 }
 
 static inline uint16_t
@@ -106,9 +108,11 @@ MULi64(int64_t a, int64_t b, bool *overflow)
 static inline int64_t
 ABSi64(int64_t a, bool *overflow)
 {
-    int64_t b = a >= 0 ? a : (int64_t)(-((uint64_t)a));
-    *overflow |= a == INT64_MIN;
-    return b;
+    if (a == INT64_MIN) {
+        *overflow = 1;
+        return INT64_MIN;
+    }
+    return a >= 0 ? a : -a;
 }
 
 static inline uint16_t