[XNIO-317] Introduce API to clean ThreadLocal caches from ByteBufferSlicePool #176

iweiss · 2019-01-25T16:08:09Z

Issue: https://issues.jboss.org/browse/XNIO-317

…licePool Issue: https://issues.jboss.org/browse/XNIO-317

wildfly-ci · 2019-01-25T16:11:43Z

Build 57 outcome was FAILURE using a merge of 011c06b
Summary: Tests failed: 7 (1 new), passed: 945, ignored: 18 Build time: 00:01:10

Failed tests

org.xnio.nio.test.MultiThreadedNioSslTcpConnectionTestCase.twoWayTransfer: java.lang.AssertionError
	at org.xnio.nio.test.AbstractNioSslTcpTest$7.run(AbstractNioSslTcpTest.java:240)
	at org.xnio.nio.test.AbstractNioTcpTest.doConnectionTest(AbstractNioTcpTest.java:102)
	at org.xnio.nio.test.NioSslTcpConnectionTestCase.doConnectionTest(NioSslTcpConnectionTestCase.java:115)
	at org.xnio.nio.test.AbstractNioSslTcpTest.twoWayTransfer(AbstractNioSslTcpTest.java:237)
------- Stderr: -------
09:11:33,894 INFO  (main) [TEST] <AbstractNioSslTcpTest.java:231> Test: twoWayTransfer
09:11:33,898 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:255> client handle readable
09:11:33,905 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,906 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,907 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,907 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,908 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,908 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,908 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,908 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,909 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,909 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,909 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,909 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,910 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,910 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,910 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,911 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,911 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,911 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,911 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,912 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,912 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,912 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,912 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,915 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,915 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,915 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,916 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,916 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,916 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,916 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,916 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,917 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,917 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,917 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,917 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,918 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,918 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,918 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,918 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,919 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,919 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,919 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable
09:11:33,920 INFO  (XNIO-45 I/O-3) [TEST] <AbstractNioSslTcpTest.java:273> client handle writable


org.xnio.racecondition.ResumeReadsOnHandlingReadableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.ResumeWritesOnHandlingWritableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.SetReadListenerOnHandlingReadableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.SetReadReadyOnHandlingReadableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.SetWriteListenerOnHandlingWritableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.SetWriteReadyOnHandlingWritableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)
------- Stdout: -------
byteman jar is /store/repository/org/jboss/byteman/byteman/3.0.3/byteman-3.0.3.jar
Setting org.jboss.byteman.allow.config.update=true
------- Stderr: -------
	at sun.instrument.InstrumentationImpl.loadClassAndStartAgent(InstrumentationImpl.java:408)
	at sun.instrument.InstrumentationImpl.loadClassAndCallAgentmain(InstrumentationImpl.java:433)
	at com.ibm.tools.attach.javaSE.Attachment.loadAgentLibraryImpl(Native Method)
	at com.ibm.tools.attach.javaSE.Attachment.loadAgentLibrary(Attachment.java:309)
	at com.ibm.tools.attach.javaSE.Attachment.parseLoadAgent(Attachment.java:287)
	at com.ibm.tools.attach.javaSE.Attachment.doCommand(Attachment.java:168)
	at com.ibm.tools.attach.javaSE.Attachment.run(Attachment.java:128)
Caused by: java.lang.UnsupportedOperationException: adding retransformable transformers is not supported in this environment
	at sun.instrument.InstrumentationImpl.addTransformer(InstrumentationImpl.java:100)
	at org.jboss.byteman.agent.Main.premain(Main.java:275)
	at org.jboss.byteman.agent.Main.agentmain(Main.java:305)
	... 11 more

iweiss · 2019-02-11T16:21:55Z

Hi @dmlloyd, can this be merged and released as well, please?

dmlloyd · 2019-02-11T16:41:41Z

Did we have a discussion about this? Normally I don't introduce new or change existing APIs in a minor branch.

iweiss · 2019-02-11T17:05:20Z

We did last year and the change ended up in 3.7 instead of 3.6

wildfly-ci · 2019-03-11T23:19:13Z

Build 62 outcome was FAILURE using a merge of 011c06b
Summary: Tests failed: 7 (1 new), passed: 945, ignored: 18 Build time: 00:09:27

Failed tests

org.xnio.ssl.JsseSslStreamConnectionTestCase.multipleFeedReadAndWriteWithSimpleHandshake: 	at org.xnio.ssl.JsseSslStreamConnectionTestCase.multipleFeedReadAndWriteWithSimpleHandshake(JsseSslStreamConnectionTestCase.java:231)
------- Stderr: -------
Exception in thread "Thread-94" java.lang.AssertionError: expected:<96> but was:<0>
	at org.xnio.ssl.JsseSslStreamConnectionTestCase$WriteRunnable.run(JsseSslStreamConnectionTestCase.java:535)
	at java.lang.Thread.run(Thread.java:785)


org.xnio.racecondition.ResumeReadsOnHandlingReadableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.ResumeWritesOnHandlingWritableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.SetReadListenerOnHandlingReadableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.SetReadReadyOnHandlingReadableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.SetWriteListenerOnHandlingWritableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.SetWriteReadyOnHandlingWritableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)
------- Stdout: -------
byteman jar is /store/repository/org/jboss/byteman/byteman/3.0.3/byteman-3.0.3.jar
Setting org.jboss.byteman.allow.config.update=true
------- Stderr: -------
	at sun.instrument.InstrumentationImpl.loadClassAndStartAgent(InstrumentationImpl.java:408)
	at sun.instrument.InstrumentationImpl.loadClassAndCallAgentmain(InstrumentationImpl.java:433)
	at com.ibm.tools.attach.javaSE.Attachment.loadAgentLibraryImpl(Native Method)
	at com.ibm.tools.attach.javaSE.Attachment.loadAgentLibrary(Attachment.java:309)
	at com.ibm.tools.attach.javaSE.Attachment.parseLoadAgent(Attachment.java:287)
	at com.ibm.tools.attach.javaSE.Attachment.doCommand(Attachment.java:168)
	at com.ibm.tools.attach.javaSE.Attachment.run(Attachment.java:128)
Caused by: java.lang.UnsupportedOperationException: adding retransformable transformers is not supported in this environment
	at sun.instrument.InstrumentationImpl.addTransformer(InstrumentationImpl.java:100)
	at org.jboss.byteman.agent.Main.premain(Main.java:275)
	at org.jboss.byteman.agent.Main.agentmain(Main.java:305)
	... 11 more

wildfly-ci · 2019-05-12T18:38:18Z

Build 80 outcome was FAILURE using a merge of 011c06b
Summary: Tests failed: 6, passed: 946, ignored: 18 Build time: 00:01:11

Failed tests

org.xnio.racecondition.ResumeReadsOnHandlingReadableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.ResumeWritesOnHandlingWritableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.SetReadListenerOnHandlingReadableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.SetReadReadyOnHandlingReadableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.SetWriteListenerOnHandlingWritableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)


org.xnio.racecondition.SetWriteReadyOnHandlingWritableChannelTestCase: java.net.ConnectException: Connection refused (Connection refused)
------- Stdout: -------
byteman jar is /store/repository/org/jboss/byteman/byteman/3.0.3/byteman-3.0.3.jar
Setting org.jboss.byteman.allow.config.update=true
------- Stderr: -------
	at sun.instrument.InstrumentationImpl.loadClassAndStartAgent(InstrumentationImpl.java:408)
	at sun.instrument.InstrumentationImpl.loadClassAndCallAgentmain(InstrumentationImpl.java:433)
	at com.ibm.tools.attach.javaSE.Attachment.loadAgentLibraryImpl(Native Method)
	at com.ibm.tools.attach.javaSE.Attachment.loadAgentLibrary(Attachment.java:309)
	at com.ibm.tools.attach.javaSE.Attachment.parseLoadAgent(Attachment.java:287)
	at com.ibm.tools.attach.javaSE.Attachment.doCommand(Attachment.java:168)
	at com.ibm.tools.attach.javaSE.Attachment.run(Attachment.java:128)
Caused by: java.lang.UnsupportedOperationException: adding retransformable transformers is not supported in this environment
	at sun.instrument.InstrumentationImpl.addTransformer(InstrumentationImpl.java:100)
	at org.jboss.byteman.agent.Main.premain(Main.java:275)
	at org.jboss.byteman.agent.Main.agentmain(Main.java:305)
	... 11 more

xstefank · 2019-07-09T05:36:12Z

@fl4via @dmlloyd this is the same change as is merged in 3.x (#142). This seems to be blocking undertow-io/undertow#604. Can this be merged, please?

dmlloyd · 2019-07-09T15:27:12Z

As I said, we don't normally merge new APIs into old branches. Can we upgrade to a 3.7 release instead?

bmaxwell · 2019-07-09T16:44:51Z

@dmlloyd / @xstefank , @fl4via had mentioned moving xnio to 3.7 related to some performance issues, do we expect any issues going from 3.6 to 3.7 in EAP 7.2.z ? If not, then we just need to make sure QE is ok with it.

mackaypeter · 2019-07-25T11:44:47Z

We did some pre-testing with 3.7 and didn't really see any issues. @fl4via, was there anything in particular you were worried about?

fl4via · 2019-07-25T18:46:43Z

@mackaypeter the only concern about upgrading to XNIO 3.7.2.Final is that it requires jboss-remoting 5.0.12.Final to prevent a deadlock (REM3-336)

fl4via · 2019-07-25T19:00:58Z

@mackaypeter btw, I advise the upgrade to XNIO 3.7.2.Final and jboss remoting because of several issues that had been fixed. I'm tagging jboss-remoting today

fl4via · 2019-07-25T19:02:00Z

@xstefank the problem with this PR are the comments in the undertow PR by @msfm , that are correct. I'm going to review the whole solution from the xnio and undertow pov and get a final solution for these issues

xstefank · 2019-07-25T19:05:30Z

@fl4via thank you. I just want to mention that EAP 7.2.x is already on remoting 5.0.12 (https://github.com/jbossas/wildfly-core-eap/blob/6.0.x/pom.xml#L178)

fl4via · 2019-08-12T04:10:33Z

Closing this because the API doest not apply to old branch

[XNIO-317] Introduce API to clean ThreadLocal caches from ByteBufferS…

011c06b

…licePool Issue: https://issues.jboss.org/browse/XNIO-317

fl4via closed this Aug 12, 2019

iweiss deleted the XNIO-317_3.6 branch August 12, 2019 12:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[XNIO-317] Introduce API to clean ThreadLocal caches from ByteBufferSlicePool #176

[XNIO-317] Introduce API to clean ThreadLocal caches from ByteBufferSlicePool #176

iweiss commented Jan 25, 2019

wildfly-ci commented Jan 25, 2019

iweiss commented Feb 11, 2019 •

edited

dmlloyd commented Feb 11, 2019

iweiss commented Feb 11, 2019

wildfly-ci commented Mar 11, 2019

wildfly-ci commented May 12, 2019

xstefank commented Jul 9, 2019

dmlloyd commented Jul 9, 2019

bmaxwell commented Jul 9, 2019

mackaypeter commented Jul 25, 2019

fl4via commented Jul 25, 2019

fl4via commented Jul 25, 2019

fl4via commented Jul 25, 2019

xstefank commented Jul 25, 2019

fl4via commented Aug 12, 2019

[XNIO-317] Introduce API to clean ThreadLocal caches from ByteBufferSlicePool #176

[XNIO-317] Introduce API to clean ThreadLocal caches from ByteBufferSlicePool #176

Conversation

iweiss commented Jan 25, 2019

wildfly-ci commented Jan 25, 2019

Failed tests

iweiss commented Feb 11, 2019 • edited

dmlloyd commented Feb 11, 2019

iweiss commented Feb 11, 2019

wildfly-ci commented Mar 11, 2019

Failed tests

wildfly-ci commented May 12, 2019

Failed tests

xstefank commented Jul 9, 2019

dmlloyd commented Jul 9, 2019

bmaxwell commented Jul 9, 2019

mackaypeter commented Jul 25, 2019

fl4via commented Jul 25, 2019

fl4via commented Jul 25, 2019

fl4via commented Jul 25, 2019

xstefank commented Jul 25, 2019

fl4via commented Aug 12, 2019

iweiss commented Feb 11, 2019 •

edited