fix(mk): remove deprecated helper-targets and adjust config-slim #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safl
force-pushed
the
fix_broken_configs
branch
from
57d4543
to
2431683
Compare
karlowich
requested changes
Sep 6, 2023
ankit-sam
reviewed
Sep 6, 2023
Makefile
Outdated
|
|
||
| define config-slim-help | ||
| # Configure Meson to compile xNVMe without: SPDK, liburing, and libvfn | ||
| # Configure Meson to compile xNVMe without any third-part libraries |
karlowich
previously approved these changes
Sep 6, 2023
The mk-config-helper-targets for various features were previously convenient as examples of disabling features requiring third-party subproject-provided libraries. However, now that the build links with the dependencies available on the system. Then, third-party dependencies are simply disabled when not available. Thus, those targets are no longer needed. The exception to this is SPDK. Thus, the 'config-slim' is an example of turning off the SPDK subproject. It also shows how to turn off a third-party library, even though it is readily available on the system. Signed-off-by: Simon A. F. Lund <simon.lund@samsung.com>
safl
force-pushed
the
fix_broken_configs
branch
from
2431683
to
992ba12
Compare
ankit-sam
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mk-config-helper-targets for various features were previously somewhat convenient as examples of disabling features requiring third-party libraries which were always fetched via meson-subprojects. Also, as a means to disable when a dependency did not function properly in a given environment.
Now that the build instead links with the dependencies when available on the system. Then, third-party dependencies simply disabled when not available. Thus, those targets are no longer needed.
The exception to this is SPDK, thus, the 'config-slim' serves as an example of disabling the SPDK subproject, and disabling other dependencies even when they are found on the system.