Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mk): remove deprecated helper-targets and adjust config-slim #340

Merged
merged 1 commit into from
Sep 6, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 7 additions & 29 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -93,43 +93,21 @@ endef
.PHONY: config-debug
config-debug:
@echo "## xNVMe: make config-debug"
CC=$(CC) CXX=$(CXX) $(MESON) setup $(BUILD_DIR) --buildtype=debug
@echo "## xNVMe: make config-debug [DONE]"

define config-uring-help
# Configure Meson to compile xNVMe without: SPDK, and libvfn
endef
.PHONY: config-uring
config-uring:
@echo "## xNVMe: config-uring"
CC=$(CC) CXX=$(CXX) $(MESON) setup $(BUILD_DIR) \
-Dwith-spdk=disabled \
-Dwith-liburing=enabled \
-Dwith-libvfn=disabled
@echo "## xNVMe: config-uring [DONE]"

define config-libvfn-help
# Configure Meson to compile xNVMe without: SPDK, and liburing
endef
.PHONY: config-libvfn
config-libvfn:
@echo "## xNVMe: config-libvfn"
CC=$(CC) CXX=$(CXX) $(MESON) setup $(BUILD_DIR) \
-Dwith-spdk=disabled \
-Dwith-liburing=disabled \
-Dwith-libvfn=enabled
@echo "## xNVMe: config-uring [DONE]"
--buildtype=debug
@echo "## xNVMe: make config-debug [DONE]"

define config-slim-help
# Configure Meson to compile xNVMe without: SPDK, liburing, and libvfn
# Configure Meson to compile xNVMe without any third-party libraries
endef
.PHONY: config-slim
config-slim:
@echo "## xNVMe: make config-slim"
CC=$(CC) CXX=$(CXX) $(MESON) setup $(BUILD_DIR) \
-Dwith-spdk=disabled \
-Dwith-liburing=disabled \
-Dwith-libvfn=disabled
-Dwith-spdk=false \
karlowich marked this conversation as resolved.
Show resolved Hide resolved
-Dwith-liburing=disabled \
-Dwith-libvfn=disabled \
-Dwith-libaio=disabled
@echo "## xNVMe: make config-slim [DONE]"

define docker-help
Expand Down