fix(arduino-cli): get rid of shell:true for all platforms

xodio · Dec 2, 2019 · 1b85eaa · 1b85eaa
1 parent 70a9cf5
commit 1b85eaa
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/packages/arduino-cli/src/index.js b/packages/arduino-cli/src/index.js
@@ -1,4 +1,3 @@
-import os from 'os';
 import * as R from 'ramda';
 import { resolve } from 'path';
 import { promisifyChildProcess } from 'promisify-child-process';
@@ -17,8 +16,6 @@ const spawn = (bin, args, options) =>
   });
 
 const noop = () => {};
-const IS_WIN = os.platform() === 'win32';
-const escapeSpacesNonWin = R.unless(() => IS_WIN, R.replace(/\s/g, '\\ '));
 
 /**
  * Initializes object to work with `arduino-cli`
@@ -36,12 +33,10 @@ const ArduinoCli = (pathToBin, config = null) => {
     runningProcesses = R.reject(R.equals(proc), runningProcesses);
   };
 
-  const escapedConfigPath = escapeSpacesNonWin(configPath);
   const runWithProgress = async (onProgress, args) => {
-    const spawnArgs = R.concat([`--config-file=${escapedConfigPath}`], args);
-    const proc = spawn(escapeSpacesNonWin(pathToBin), spawnArgs, {
+    const spawnArgs = R.concat([`--config-file=${configPath}`], args);
+    const proc = spawn(pathToBin, spawnArgs, {
       stdio: ['inherit', 'pipe', 'pipe'],
-      shell: !IS_WIN, // TODO: Can we get rid of `shell: true` for other platforms?
     });
     proc.stdout.on('data', data => onProgress(data.toString()));
     proc.stderr.on('data', data => onProgress(data.toString()));