Fix [Object object] in deploy pane messages #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brusherru
approved these changes
May 10, 2018
evgenykochetkov
approved these changes
May 10, 2018
nkrkv
force-pushed
the
fix-1080-object-object-error
branch
from
2c1473f
to
e6f3515
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1080
The root cause is
ERROR_FORMATTERShad an impossible type. Some values were strings, other were objects. A non-uniform typing became a source of troubles, again. Please, don’t use such magic in your code: if something can’t have a sane signature it is wrong and should be rewritten.