Wrap output pin values with pragmas only once #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkrkv
reviewed
Jul 10, 2018
| {{#each outputs }} | ||
| {{ decltype type value }} node_{{ ../id }}_output_{{ pinKey }} = {{ cppValue type value }}; | ||
| {{/each}} | ||
| {{/each}} | ||
| #pragma GCC diagnostic pop |
There was a problem hiding this comment.
Please, add a blank line right above #pragma GCC diagnostic pop
evgenykochetkov
approved these changes
Jul 11, 2018
brusherru
force-pushed
the
fix-pragmas
branch
2 times, most recently
from
7e9d230
to
ea60003
Compare
This was referenced Aug 5, 2021
This was referenced Sep 1, 2021
This was referenced Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be in PR #1322 🙈