Shortcuts for buses #1397
Merged
Shortcuts for buses #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenykochetkov
force-pushed
the
feat-1365-shortcuts-for-buses
branch
from
a1fdc67
to
cb5daff
Compare
nkrkv
requested changes
Aug 8, 2018
There was a problem hiding this comment.
Great clear code 👍
One thing I find Reasonable is instead of renaming Sorry my delirium, there’s no such thing as Holes.List.groupBy to Holes.List.groupByString move it to Holes.List.String.groupBy so that the Belt convention is keptBelt.List.String. The code is OK
|
Did not hard-tested the functionality yet |
evgenykochetkov
force-pushed
the
feat-1365-shortcuts-for-buses
branch
from
cb5daff
to
a6d32dc
Compare
brusherru
approved these changes
Aug 9, 2018
|
One thing nice to have which was not described in the issue is some special terminal handling. Steps to reproduce
Desired behaviorThe bus gets label Actual behaviorThe bus gets label |
evgenykochetkov
force-pushed
the
feat-1365-shortcuts-for-buses
branch
from
a6d32dc
to
29cba2e
Compare
… return Project.t instead of Result
…): shortcuts for creating bus nodes Closes #1365
evgenykochetkov
force-pushed
the
feat-1365-shortcuts-for-buses
branch
from
3a7eadb
to
0f97ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1365
Also see xodio/xod-docs#52