Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly induce variadic labels for pins with numeric labels #1470

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Correctly induce variadic labels for pins with numeric labels #1470

merged 1 commit into from
Oct 16, 2018

Conversation

evgenykochetkov
Copy link
Contributor

Fixes #1468

@evgenykochetkov evgenykochetkov self-assigned this Oct 15, 2018
nkrkv
nkrkv reviewed Oct 15, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And can we place an additional guard somehow so that even with the bug in induceVariadicPinLabel the IDE would not crash to the gray screen?

brusherru
brusherru approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nkrkv
nkrkv approved these changes Oct 15, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the protection is not trivial. Should be a separate issue.

👍

@evgenykochetkov evgenykochetkov force-pushed the fix-1468-crash-on-numeric-labeled-variadic-pins branch from 7642d0a to a49593b Compare October 16, 2018 07:43
@evgenykochetkov evgenykochetkov merged commit f96fa6d into master Oct 16, 2018
@evgenykochetkov evgenykochetkov deleted the fix-1468-crash-on-numeric-labeled-variadic-pins branch October 16, 2018 08:01
@nkrkv nkrkv mentioned this pull request Oct 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@brusherru brusherru brusherru approved these changes

Assignees

@evgenykochetkov evgenykochetkov

Labels
s:core t:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgenykochetkov @nkrkv @brusherru