Select all patch entities or input contents from menu item #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkrkv
requested changes
Oct 25, 2018
| @@ -575,7 +575,19 @@ class App extends client.App { | |||
| items.cut, | |||
| items.copy, | |||
| items.paste, | |||
| items.selectall, | |||
| onClick(items.selectall, () => { | |||
There was a problem hiding this comment.
Too complex function for the purely structural code span. Suggest extracting it to a method
| @@ -575,7 +575,19 @@ class App extends client.App { | |||
| items.cut, | |||
| items.copy, | |||
| items.paste, | |||
| items.selectall, | |||
| onClick(items.selectall, () => { | |||
| // We can't use `role: 'selectall'` here, cause it ignores `onClick`. | |||
brusherru
force-pushed
the
fix-1497-select-all
branch
from
87e640c
to
ca25af7
Compare
|
@nkrkv check it out, please |
brusherru
force-pushed
the
fix-1497-select-all
branch
2 times, most recently
from
50de875
to
1d44f5f
Compare
|
@nkrkv check it out, please |
nkrkv
requested changes
Oct 29, 2018
brusherru
force-pushed
the
fix-1497-select-all
branch
from
1d44f5f
to
41ddd3c
Compare
|
@nkrkv Oops. My bad. |
brusherru
force-pushed
the
fix-1497-select-all
branch
from
e4f7076
to
3478f7f
Compare
|
@nkrkv finally, it has to work. |
nkrkv
approved these changes
Oct 30, 2018
| /** | ||
| * We have to handle some hotkeys, because: | ||
| * - Browser IDE should prevent default event handling | ||
| * - Electron IDE could not handle correct some hotkeys. |
There was a problem hiding this comment.
📜 Electron IDE cannot handle some hotkeys correctly
brusherru
force-pushed
the
fix-1497-select-all
branch
from
3478f7f
to
1994aa5
Compare
…ects all entities on the Patch or all in the input if it focused
brusherru
force-pushed
the
fix-1497-select-all
branch
from
1994aa5
to
9622f0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #1497.
Also, I've added "Select All" menu item into browser version of the IDE, that selects all entities on the Patch.