Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise DTR when opening serialport on windows #1507

Merged

Conversation

evgenykochetkov
Copy link
Contributor

It causes issues with some boards using CP2102 USB to Serial chip

Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Linux, nothing has broken.

Bravo for the incredibly deep investigation! 🥇

@evgenykochetkov evgenykochetkov force-pushed the fix-dont-raise-dtr-when-opening-serialport-on-windows branch from ce8d9f6 to 95871b9 Compare October 26, 2018 11:48
@evgenykochetkov evgenykochetkov merged commit 360c4ba into 0.25.x Oct 26, 2018
@evgenykochetkov evgenykochetkov deleted the fix-dont-raise-dtr-when-opening-serialport-on-windows branch October 26, 2018 12:13
@nkrkv nkrkv added the hotfix Issue/PR for a patch release label Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix Issue/PR for a patch release s:client t:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants