Handle package indexes update fails #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brusherru
force-pushed
the
fix-1506-silent-update-index
branch
from
b6a9ba0
to
cf7d057
Compare
nkrkv
changed the title
brusherru
force-pushed
the
fix-1506-silent-update-index
branch
from
cf7d057
to
d82c286
Compare
|
@nkrkv updated. Check it out, please! |
brusherru
force-pushed
the
fix-1506-silent-update-index
branch
from
d82c286
to
d2d30ce
Compare
brusherru
force-pushed
the
fix-1506-silent-update-index
branch
from
d2d30ce
to
ec01845
Compare
|
@nkrkv check it out, please! |
brusherru
force-pushed
the
fix-1506-silent-update-index
branch
from
ec01845
to
c87bae7
Compare
evgenykochetkov
requested changes
Oct 31, 2018
brusherru
force-pushed
the
fix-1506-silent-update-index
branch
from
c87bae7
to
a69eeea
Compare
|
@evgenykochetkov fixed! Check it out, please |
evgenykochetkov
requested changes
Oct 31, 2018
brusherru
force-pushed
the
fix-1506-silent-update-index
branch
from
a69eeea
to
ed9d5a1
Compare
|
@evgenykochetkov fixed! Check it out, please |
|
@nkrkv check it out, please :) |
brusherru
force-pushed
the
fix-1506-silent-update-index
branch
from
ed9d5a1
to
f23e917
Compare
evgenykochetkov
approved these changes
Nov 1, 2018
brusherru
force-pushed
the
fix-1506-silent-update-index
branch
2 times, most recently
from
32c0a33
to
6c10fea
Compare
|
@evgenykochetkov @nkrkv check it out, please! |
nkrkv
requested changes
Nov 2, 2018
There was a problem hiding this comment.
😢 Just a straightforward test: checkout, build, start, Deploy → Upload:
Package index broken
Error: null does not have a method named "split"
Check correctness of the corresponding URL in "/home/nailxx/devel/xod-workspace/__packages__/extra.txt" and try to update indexes again
Yes, I have an empty extra.txt like most of the current users are.
brusherru
force-pushed
the
fix-1506-silent-update-index
branch
from
6c10fea
to
f56bf7f
Compare
…xUrls` (do not mutate) and list not installed boards using URLs from `.cli-config.yml` (as arduino-cli does)
…nds that could fail updating package indexes
brusherru
force-pushed
the
fix-1506-silent-update-index
branch
from
f56bf7f
to
7c6b558
Compare
…ting and place bundled package urls in the `extra.txt`
brusherru
force-pushed
the
fix-1506-silent-update-index
branch
from
7c6b558
to
57d2723
Compare
|
@nkrkv fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it will show an error message and remove new URLs from
.cli-config.ymlthat could cause errors (but left downloaded files in the__packages__directory to make possible to inspect what is really went wrong).So IDE will be usable after the error.
It fixes #1506