-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle package indexes update fails #1509
Conversation
b6a9ba0
to
cf7d057
Compare
cf7d057
to
d82c286
Compare
@nkrkv updated. Check it out, please! |
d82c286
to
d2d30ce
Compare
d2d30ce
to
ec01845
Compare
@nkrkv check it out, please! |
ec01845
to
c87bae7
Compare
c87bae7
to
a69eeea
Compare
@evgenykochetkov fixed! Check it out, please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a69eeea
to
ed9d5a1
Compare
@evgenykochetkov fixed! Check it out, please |
@nkrkv check it out, please :) |
ed9d5a1
to
f23e917
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm 👍🏻
32c0a33
to
6c10fea
Compare
@evgenykochetkov @nkrkv check it out, please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢 Just a straightforward test: checkout, build, start, Deploy → Upload:
Package index broken
Error: null does not have a method named "split"
Check correctness of the corresponding URL in "/home/nailxx/devel/xod-workspace/__packages__/extra.txt" and try to update indexes again
Yes, I have an empty extra.txt
like most of the current users are.
6c10fea
to
f56bf7f
Compare
…xUrls` (do not mutate) and list not installed boards using URLs from `.cli-config.yml` (as arduino-cli does)
…nds that could fail updating package indexes
f56bf7f
to
7c6b558
Compare
…ting and place bundled package urls in the `extra.txt`
7c6b558
to
57d2723
Compare
@nkrkv fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, finally, LGTM
Now it will show an error message and remove new URLs from
.cli-config.yml
that could cause errors (but left downloaded files in the__packages__
directory to make possible to inspect what is really went wrong).So IDE will be usable after the error.
It fixes #1506