Make sure generated C++ is compatible with STM32 boards #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkrkv
requested changes
Oct 30, 2018
| @@ -6,7 +6,7 @@ const LEADING_CHAR = 'D'; | |||
| // :: DataValue -> DataValue | |||
| export default input => | |||
| R.unless( | |||
| R.test(/^(A|D)\d+/i), | |||
| R.test(/^(P[A-F]|A|D)\d+$/), | |||
There was a problem hiding this comment.
I worry a bit about the regex. It is complex and almost matches the one used in packages/xod-project/src/utils.js:220: R.test(/^(P[A-F]|A|D)\d{0,3}$/g, literal). I suggest extracting the test to a function like isValidNumberDataValue we have already.
evgenykochetkov
force-pushed
the
fix-cpp-stm32-compatibility
branch
from
ff70c8c
to
9ab4fee
Compare
brusherru
approved these changes
Oct 30, 2018
evgenykochetkov
force-pushed
the
fix-cpp-stm32-compatibility
branch
2 times, most recently
from
23ac933
to
d24792c
Compare
…\d` form For example, `PA13` or `PB8`
evgenykochetkov
force-pushed
the
fix-cpp-stm32-compatibility
branch
from
d24792c
to
0e18309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PA13,PB8etcdtostrf, the built-in one is fine