Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing formatter for error about too many outputs #1568

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Add missing formatter for error about too many outputs #1568

merged 1 commit into from
Nov 27, 2018

Conversation

evgenykochetkov
Copy link
Contributor

Closes #1545

@evgenykochetkov evgenykochetkov self-assigned this Nov 26, 2018
brusherru
brusherru approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

nkrkv
nkrkv approved these changes Nov 26, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nkrkv
nkrkv reviewed Nov 26, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be in master?

@evgenykochetkov evgenykochetkov force-pushed the fix-1545-missing-error-formatter-when-too-many-outputs branch from 4f630e6 to ad4256f Compare November 27, 2018 11:12
@evgenykochetkov evgenykochetkov changed the base branch from 0.25.x to master November 27, 2018 11:12
@evgenykochetkov
Copy link
Contributor Author

Yep, changed base to master

@evgenykochetkov evgenykochetkov force-pushed the fix-1545-missing-error-formatter-when-too-many-outputs branch from ad4256f to 758aab6 Compare November 27, 2018 13:33
@evgenykochetkov evgenykochetkov force-pushed the fix-1545-missing-error-formatter-when-too-many-outputs branch from 758aab6 to f11156d Compare November 27, 2018 15:38
@evgenykochetkov evgenykochetkov merged commit 1865cd5 into master Nov 27, 2018
@evgenykochetkov evgenykochetkov deleted the fix-1545-missing-error-formatter-when-too-many-outputs branch November 27, 2018 16:03
@evgenykochetkov evgenykochetkov mentioned this pull request Dec 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@brusherru brusherru brusherru approved these changes

Assignees

@evgenykochetkov evgenykochetkov

Labels
s:client t:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgenykochetkov @nkrkv @brusherru