Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore some dirnames while reading directories #1600

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Ignore some dirnames while reading directories #1600

merged 1 commit into from
Dec 26, 2018

Conversation

brusherru
Copy link
Contributor

It fixes #1597

@brusherru brusherru self-assigned this Dec 25, 2018
@brusherru brusherru force-pushed the fix-1597-skip-special-files-in-lib-dir branch from 2f6e116 to d746c25 Compare December 25, 2018 17:43
nkrkv
nkrkv approved these changes Dec 26, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce (emulate) and ensure this fix works on Linux.

Please note the comment from @knopki, fix, and merge

@brusherru brusherru force-pushed the fix-1597-skip-special-files-in-lib-dir branch from d746c25 to 85a4a90 Compare December 26, 2018 10:07
@brusherru brusherru merged commit 81ae4ba into master Dec 26, 2018
@brusherru brusherru deleted the fix-1597-skip-special-files-in-lib-dir branch December 26, 2018 10:24
@evgenykochetkov evgenykochetkov mentioned this pull request Dec 26, 2018
Merged
@Cesar-S
Copy link
Contributor

Cesar-S commented Jan 11, 2019

Hi @evgenykochetkov , it is possible to include _gsdata_, it belongs to GoodSync.
Change Google Drive to GoodSync, it's more advanced.
When I guarded xodball, I realized that it took that folder.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knopki knopki knopki left review comments

@nkrkv nkrkv nkrkv approved these changes

@evgenykochetkov evgenykochetkov Awaiting requested review from evgenykochetkov

Assignees

@brusherru brusherru

Labels
t:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XOD fails to load if Google Drive sync is in progress
4 participants
@brusherru @Cesar-S @nkrkv @knopki