Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ implementation for tweak nodes #1662

Merged
merged 1 commit into from
Feb 6, 2019
Merged

C++ implementation for tweak nodes #1662

merged 1 commit into from
Feb 6, 2019

Conversation

evgenykochetkov
Copy link
Contributor

@evgenykochetkov evgenykochetkov commented Feb 4, 2019 •
edited

Would appreciate feedback about messages format (do we need to begin them with some unique symbol to avoid consuming all serial input?)

@evgenykochetkov evgenykochetkov self-assigned this Feb 4, 2019
@evgenykochetkov evgenykochetkov force-pushed the feat-tweak-nodes-cpp-implementation branch from ae12073 to e4f58c0 Compare February 4, 2019 15:00
@evgenykochetkov evgenykochetkov force-pushed the feat-tweak-nodes-cpp-implementation branch from e4f58c0 to 29e5066 Compare February 4, 2019 16:02
nkrkv
nkrkv requested changes Feb 4, 2019
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May we have descriptions in tweak-* nodes?

Outputs a fixed numerical value which you may change in real-time during a debug or simulation session

workspace/__lib__/xod/debug/tweak-string-16/patch.cpp Outdated Show resolved Hide resolved
workspace/__lib__/xod/debug/tweak-byte/patch.cpp Outdated Show resolved Hide resolved
packages/xod-arduino/platform/program.tpl.cpp Outdated Show resolved Hide resolved
@evgenykochetkov evgenykochetkov force-pushed the feat-tweak-nodes-cpp-implementation branch 2 times, most recently from d8fccd8 to 0dcb930 Compare February 4, 2019 22:12
nkrkv
nkrkv approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@evgenykochetkov evgenykochetkov force-pushed the feat-send-data-to-serial branch 2 times, most recently from 93ab5a0 to ae85e65 Compare February 5, 2019 16:09
@evgenykochetkov evgenykochetkov force-pushed the feat-tweak-nodes-cpp-implementation branch 2 times, most recently from 2a4e9f9 to f272e28 Compare February 6, 2019 09:34
@evgenykochetkov evgenykochetkov changed the base branch from feat-send-data-to-serial to master February 6, 2019 09:35
@evgenykochetkov evgenykochetkov force-pushed the feat-tweak-nodes-cpp-implementation branch from f272e28 to a2e921c Compare February 6, 2019 09:40
@evgenykochetkov evgenykochetkov merged commit 1be9cd3 into master Feb 6, 2019
@evgenykochetkov evgenykochetkov deleted the feat-tweak-nodes-cpp-implementation branch February 6, 2019 10:01
@evgenykochetkov evgenykochetkov mentioned this pull request Feb 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brusherru brusherru brusherru left review comments

@nkrkv nkrkv nkrkv approved these changes

Assignees

@evgenykochetkov evgenykochetkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evgenykochetkov @nkrkv @brusherru