Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce nodes and C++ API for error handling #1777

Merged
merged 6 commits into from
May 31, 2019
Merged

Introduce nodes and C++ API for error handling #1777

merged 6 commits into from
May 31, 2019

Conversation

evgenykochetkov
Copy link
Contributor

@evgenykochetkov evgenykochetkov commented May 13, 2019 •
edited
Loading

Closes #1769
Closes #1771

@evgenykochetkov evgenykochetkov self-assigned this May 13, 2019
@evgenykochetkov evgenykochetkov force-pushed the feat-errors branch 3 times, most recently from 4bb07b7 to f9ab9ba Compare May 14, 2019 13:04
brusherru
brusherru approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nkrkv
nkrkv requested changes May 14, 2019
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

packages/xod-arduino/src/Directives.re Outdated Show resolved Hide resolved
packages/xod-arduino/src/Directives.re Outdated Show resolved Hide resolved
packages/xod-project/src/utils.js Outdated Show resolved Hide resolved
workspace/__lib__/xod/core/cast-to-string(errcode)/patch.cpp Show resolved Hide resolved
@evgenykochetkov evgenykochetkov force-pushed the feat-errors branch 4 times, most recently from 2ae17d7 to 3f9e26e Compare May 16, 2019 14:18
@evgenykochetkov evgenykochetkov force-pushed the feat-errors branch 2 times, most recently from f04ba07 to 1b028ce Compare May 21, 2019 14:43
nkrkv
nkrkv requested changes May 22, 2019
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the context object, an error should be computed for each input pin, not for the whole node

packages/xod-arduino/platform/program.tpl.cpp Outdated Show resolved Hide resolved
packages/xod-arduino/platform/runtime.cpp Outdated Show resolved Hide resolved
brusherru
brusherru reviewed May 27, 2019
View reviewed changes
packages/xod-client/src/utils/normalizeErrcode.js
x => parseInt(x, 10),
R.defaultTo(0),
R.min(127),
R.max(0),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes possible to bind "E0" to the "error" node. So when it receives a True into "ERR" pin — it does nothing... 🤔

nkrkv
nkrkv approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@evgenykochetkov
tweak(xod-func-tools): make signature for maybeProp less strict
c9ed286 
Before it would complain about `maybeProp(‘a’, {a: ‘foo’, b: []})`
@evgenykochetkov
feat(xod-arduino): add C++ support for errors concept
ed841dc 
- adds `raiseError(ctx)` and `getError<input_IN>(ctx) ` functions  to C++ API;
- adds `#pragma XOD error_catch` and `#pragma XOD error_raise`
- reports raised and cleared errors to serial in debug mode
brusherru
brusherru approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM 😄

@evgenykochetkov evgenykochetkov merged commit 84b2507 into master May 31, 2019
@evgenykochetkov evgenykochetkov deleted the feat-errors branch July 16, 2019 14:35
@nkrkv nkrkv mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@brusherru brusherru brusherru approved these changes

Assignees

@evgenykochetkov evgenykochetkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make watch node catch errors Implement errors
3 participants
@evgenykochetkov @nkrkv @brusherru