Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure implementation keywords are always detected correctly #2035

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Make sure implementation keywords are always detected correctly #2035

merged 1 commit into from
Sep 15, 2020

Conversation

evgenykochetkov
Copy link
Contributor

@evgenykochetkov evgenykochetkov commented Sep 14, 2020 •
edited
Loading

Makes identifiers that contain keywords node, nodespace and meta always parse as identifiers, not keywords.

@evgenykochetkov evgenykochetkov self-assigned this Sep 14, 2020
brusherru
brusherru approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@evgenykochetkov evgenykochetkov merged commit c2a7168 into 0.35.x Sep 15, 2020
@evgenykochetkov evgenykochetkov deleted the improve-impl-keywords-detection branch September 15, 2020 09:50
@evgenykochetkov evgenykochetkov mentioned this pull request Sep 15, 2020
Merged
@brusherru brusherru mentioned this pull request Sep 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@brusherru brusherru brusherru approved these changes

Assignees

@evgenykochetkov evgenykochetkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgenykochetkov @nkrkv @brusherru