Support esp32 boards #2038
Merged
Support esp32 boards #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkrkv
requested changes
Sep 15, 2020
| // Catch error produced by arduino-cli, but actually it's not an error: | ||
| // When User added a new URL into `extra.txt` file it causes that | ||
| // arduino-cli tries to read new JSON but it's not existing yet | ||
| // so it fails with error "no such file or directory" | ||
| // To avoid this and make a good UX, we'll force call `updateIndexes` | ||
| return updateIndexesInternal(wsPath, cli).then(() => listBoards(cli)); | ||
| return updateIndexesInternal(wsPath, cli).then(() => |
There was a problem hiding this comment.
The comment above is stale now. Needs update.
There was a problem hiding this comment.
🤔
It still actual, but I'll edit it a bit.
brusherru
force-pushed
the
feat-stdlib-support-esp32
branch
from
2c39f79
to
a25e12b
Compare
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
extra.txt: updated arduino-cli returns "ENOENT" code instead of6when JSON file is not found and ourcatchdoes not work as expected. This bug does not break a loading new file, but it shows an error message, and list of boards appears only after clicking "Update" button or opening of the upload popup next time.xod-dev/servo/servo-deviceandxod/gpio/pwm-writeto use the bundled library and work fine on ESP32