Skip to content

Commit

Permalink
Merge pull request #84 from 42Partner/enhancement/#83-threadpool-DBCP…
Browse files Browse the repository at this point in the history
…-takim

feature: @Asnyc Thread pool 지정
  • Loading branch information
xogml123 committed May 5, 2023
2 parents b3c912b + b9bf7d0 commit 43a3502
Show file tree
Hide file tree
Showing 6 changed files with 37 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package partner42.moduleapi.config.async;

import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.scheduling.concurrent.ThreadPoolTaskExecutor;

@Configuration
public class AsyncThreadPoolConfig {

/**
* Async Thread pool 별도 사용
*/
@Bean
public ThreadPoolTaskExecutor threadPoolTaskExecutor() {
ThreadPoolTaskExecutor threadPoolTaskExecutor = new ThreadPoolTaskExecutor();
threadPoolTaskExecutor.setCorePoolSize(5);
threadPoolTaskExecutor.setMaxPoolSize(10);
threadPoolTaskExecutor.setQueueCapacity(100);
threadPoolTaskExecutor.setKeepAliveSeconds(60);
return threadPoolTaskExecutor;
}

}




Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public class AlarmController {
@GetMapping("/alarms")
public Slice<AlarmDto> readAllAlarms(@ApiParam(hidden = true) @AuthenticationPrincipal UserDetails user,
Pageable pageable) {
log.info("readAllAlarms{}", Thread.currentThread().getName());
return alarmService.sendAlarmSliceAndIsReadToTrue(pageable, user.getUsername());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ public class ArticleController {
public ArticleReadOneResponse readOneArticle(
@PathVariable String articleId,
@Parameter(hidden = true) @AuthenticationPrincipal UserDetails user) {

String username = user != null ? user.getUsername() : null;
return articleService.readOneArticle(username, articleId);
}
Expand All @@ -68,6 +67,7 @@ public SliceImpl<ArticleReadResponse> readAllArticle(Pageable pageable, ArticleS
public ArticleOnlyIdResponse writeArticle(
@ApiParam(hidden = true) @AuthenticationPrincipal UserDetails user,
@Validated @Parameter @RequestBody ArticleDto articleRequest) {

if (LocalDate.now().isAfter(articleRequest.getDate())){
throw new InvalidInputException(ErrorCode.ARTICLE_DATE_IS_PAST);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@ public ArticleReadOneResponse readOneArticle(String username, String articleId)

public SliceImpl<ArticleReadResponse> readAllArticle(Pageable pageable,
ArticleSearch condition) {
log.info("readAllArticle: {}", Thread.currentThread().getName());

Slice<Article> articleSlices = articleRepository.findSliceByCondition(pageable,
condition);
return new SliceImpl<>(articleSlices.getContent().stream()
Expand Down
2 changes: 1 addition & 1 deletion module-api/src/main/resources/logback-spring-local.xml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</layout>
</appender>

<root level="DEBUG">
<root level="INFO">
<appender-ref ref="CONSOLE3" />
</root>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ public class SlackBotService {

public final SlackBotApi slackBotApi;

@Async
/**
* Async Thread pool 별도 사용
* @param emails
*/
@Async("threadPoolTaskExecutor")
public void createSlackMIIM(List<String> emails) {
List<String> slackIds = emails.stream()
.map(email ->
Expand Down

0 comments on commit 43a3502

Please sign in to comment.