Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed race condition for parallel use case #54

Merged

Conversation

lamchakchan
Copy link
Contributor

Description

  • There was a bug when any of the methods that leveraged _autoConnectChannel was invoked in a parallel fashion raising a race condition on side to side instantiations of TCP connections. A semaphore is put in place to prevent this.

Related Issue

Motivation and Context

Bug

Types of changes

  • Documentation only (no changes to either lib/ or test/ files)
  • Bug fix (non-breaking change which fixes an issue. you didn't modify existing tests)
  • New feature (non-breaking change which adds functionality. you added at least one new test)
  • Breaking change (fix or feature that would cause existing functionality to change. you had to modify existing tests.)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the Hapi.js style guide.
  • I have updated the documentation as needed.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lamchakchan lamchakchan added this to the 2.0.1 milestone Feb 23, 2017
@lamchakchan lamchakchan merged commit c0be327 into xogroup:master Feb 23, 2017
@lamchakchan lamchakchan deleted the 53-connection-init-race-condition branch February 23, 2017 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant