Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable permissive max-len and max-lines as warning #84

Merged
merged 7 commits into from
Jul 28, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@
radix: 'error',

// Disabled for now as it causes too much churn
// TODO: Enable it in the future when I have time to deal with

Check warning on line 214 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 16

Unexpected 'todo' comment: 'TODO: Enable it in the future when I...'

Check warning on line 214 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 14

Unexpected 'todo' comment: 'TODO: Enable it in the future when I...'

Check warning on line 214 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 16

Unexpected 'todo' comment: 'TODO: Enable it in the future when I...'

Check warning on line 214 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 12

Unexpected 'todo' comment: 'TODO: Enable it in the future when I...'

Check warning on line 214 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 14

Unexpected 'todo' comment: 'TODO: Enable it in the future when I...'

Check warning on line 214 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 12

Unexpected 'todo' comment: 'TODO: Enable it in the future when I...'
// the churn and the rule is stable and has an autofixer.
// Still doesn't have a fixer as of ESLint 7.24.0.
// 'require-unicode-regexp': 'error',
Expand All @@ -229,7 +229,7 @@
'no-restricted-globals': [
'error',
'event',
// TODO: Enable this in 2025.

Check warning on line 232 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 16

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 232 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 14

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 232 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 16

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 232 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 12

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 232 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 14

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 232 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 12

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'
// {
// name: 'Buffer',
// message: 'Use Uint8Array instead. See: https://sindresorhus.com/blog/goodbye-nodejs-buffer',
Expand Down Expand Up @@ -273,7 +273,7 @@
'sys',
'querystring',
'colors',
// TODO: Enable this in 2025.

Check warning on line 276 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 16

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 276 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 14

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 276 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 16

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 276 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 12

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 276 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 14

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 276 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 12

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'
// {
// name: 'buffer',
// message: 'Use Uint8Array instead. See: https://sindresorhus.com/blog/goodbye-nodejs-buffer',
Expand Down Expand Up @@ -409,6 +409,21 @@
},
],
'max-depth': 'warn',
'max-len': [
'warn',
{
code: 200,
ignoreComments: true,
ignoreUrls: true,
},
],
sindresorhus marked this conversation as resolved.
Show resolved Hide resolved
'max-lines': [
'warn',
{
max: 1500,
skipComments: true,
},
],
'max-nested-callbacks': [
'warn',
4,
Expand Down Expand Up @@ -644,7 +659,7 @@
{
// `array` is disabled because it forces destructuring on
// stupid stuff like `foo.bar = process.argv[2];`
// TODO: Open ESLint issue about this

Check warning on line 662 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 16

Unexpected 'todo' comment: 'TODO: Open ESLint issue about this'

Check warning on line 662 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 14

Unexpected 'todo' comment: 'TODO: Open ESLint issue about this'

Check warning on line 662 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 16

Unexpected 'todo' comment: 'TODO: Open ESLint issue about this'

Check warning on line 662 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 12

Unexpected 'todo' comment: 'TODO: Open ESLint issue about this'

Check warning on line 662 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 14

Unexpected 'todo' comment: 'TODO: Open ESLint issue about this'

Check warning on line 662 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 12

Unexpected 'todo' comment: 'TODO: Open ESLint issue about this'
VariableDeclarator: {
array: false,
object: true,
Expand Down