add eslint-plugin-import

[sindresorhus]

https://github.com/benmosher/eslint-plugin-import (@benmosher fyi)

@jamestalmage @novemberborn @vdemedes @kevva @SamVerschueren @jfmengels and anyone looking. I could use some help with testing this. Git checkout out this PR locally, npm link it globally, and run xo --no-local on your projects to see if there are any problems (not lint violation, unless it's wrong).

Known issues:

• Don't try to read imported JSON files: Don't try to read imported JSON files import-js/eslint-plugin-import#267
• Support optionalDependencies in the no-extraneous-dependencies rule: Support optionalDependencies in the no-extraneous-dependencies rule import-js/eslint-plugin-import#266
• The newline-after-import rule requires newline after every import: The newline-after-import rule requires newline after every import import-js/eslint-plugin-import#318
• Ignore CommonJS exports in the named rule: Ignore CommonJS exports in the named rule import-js/eslint-plugin-import#268
• Add ability to ignore certain packages from all rules: Add ability to ignore certain packages from all rules import-js/eslint-plugin-import#275
• Lodash modularized libs cause false positive for import/extensions Lodash modularized libs cause false positive for import/extensions import-js/eslint-plugin-import#378

(Help welcome for those)

[novemberborn]

@sindresorhus I don't actually use xo in my own projects, so no comment from me really 😄

The plugin looks really cool though, I'll probably add it to https://github.com/novemberborn/as-i-preach when I have some time.

[jamestalmage]

RE: as-i-preach.

Oh - you're one of those semicolon haters.

[sindresorhus]

@novemberborn Yeah, no worries. This is more about finding bugs in the import plugin, so same result if you add the plugin to your own shareable config and run ESLint on your projects.

[novemberborn]

Oh - you're one of those semicolon haters.

I just feel so much freer without them!

[jamestalmage]

I think we should debate this at length and totally hijack this thread. Great use of everyone's time.

[sindresorhus]

[adriantoine]

Does XO support the ignore and resolver settings?

[sindresorhus]

@adriantoine Not directly. We have a rules option where you can override and define rules for any plugin, including this one.

[jfmengels]

Support optionalDependencies in the no-extraneous-dependencies rule: import-js/eslint-plugin-import#266

Landed in v1.7.0

[benmosher]

Just published v1.7.0 to npm. It doesn't address all the issues @sindresorhus raised, yet, but a number of them are resolved.

[sindresorhus]

Thanks for fixing some of the issues. PR updated. We're getting closer to a merge :)

[sindresorhus]

Discovered another issue: import-js/eslint-plugin-import#378

[sindresorhus]

This PR has been opened long enough. I've disabled the offending rules for now and opened an issue to track them: #124

Thanks everyone for participating :D