-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect missing dependencies #15
Comments
I think you can do that with what is going on in import-js/eslint-plugin-import#241, by running ESLint with this rule
If you have neither of those fields set, the tool will have to get really smart about what are "production" files, and what are "dev" files. I'd say if you don't have those, you should not attempt this, as it will almost always fail. |
Would be quite straightforward to implement now that we are using JavaScript as implementation language. |
@SamVerschueren I'm going to implement that in XO, so don't think this is needed anymore: xojs/xo#109 |
Not for us but maybe people that use ESLint instead of the superior XO ;) |
@SamVerschueren They can still use that plugin themselves though. I just think depending on ESLint by default here is a bit heavy and I don't want to deal with support stuff about it. |
Yeah, good point! |
I think this can be closed |
Meaning, dependencies required/imported in the module, but not defined in
dependencies
. To ensure I don't publish a release that has the dependency incorrectly in thedevDependencies
field. Like in the sindresorhus/grunt-concurrent#85 case. Could maybe be a ESLint rule.The text was updated successfully, but these errors were encountered: