-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated --compact
CLI flag
#293
Conversation
There's also a test using this option in |
And can you update the PR title to be more specific about what's being fixed. |
Will do! |
--compact
CLI flag
test/main.js
Outdated
@@ -7,7 +7,8 @@ import tempWrite from 'temp-write'; | |||
|
|||
process.chdir(__dirname); | |||
|
|||
const main = (args, opts) => execa(path.join(__dirname, '../main.js'), args, opts); | |||
const main = (args, opts) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. My prettier accidentally prettified this line. I can remove if needed
test/main.js
Outdated
} catch (err) { | ||
t.true(err.stdout.indexOf('Error - ') !== -1); | ||
} | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I misread this code. It should not be removed. It's not using the compact
option.
test/main.js
Outdated
@@ -7,7 +7,8 @@ import tempWrite from 'temp-write'; | |||
|
|||
process.chdir(__dirname); | |||
|
|||
const main = (args, opts) => execa(path.join(__dirname, '../main.js'), args, opts); | |||
const main = (args, opts) => | |||
execa(path.join(__dirname, '../main.js'), args, opts); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't do unrelated changes.
Great, thank you :) |
#289