Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on pyreadline may cause breaking incompatibility in Python 3.9 #44

Closed
brawner opened this issue Sep 2, 2020 · 2 comments · Fixed by #45
Closed

Dependency on pyreadline may cause breaking incompatibility in Python 3.9 #44

brawner opened this issue Sep 2, 2020 · 2 comments · Fixed by #45

Comments

@brawner
Copy link

brawner commented Sep 2, 2020

We've been noticing a deprecation warning in our python stack due to pyreadline, which is a dependency of this package. Unfortunately, pyreadline has not been updated in quite a bit and is likely abandoned at this point, which yields little hope the deprecation will be resolved by the release date of Python 3.9. It might make sense to remove the dependency on pyreadline for Windows with Python >= 3.9

Upstream issue for collections deprecation
pyreadline/pyreadline#65

@aggieNick02
Copy link

The upstream issue notes that this is currently a hard break in python 3.10. I'd like to use humanfriendly on windows for some simple parsing of file size strings, but having to add abandoned pyreadline and knowing it'll break with python 3.10 is more trouble than the benefits of not reinventing a small wheel. :-)

@xolox
Copy link
Owner

xolox commented Sep 17, 2021

#45 has now been merged so this issue should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants