Skip to content

Commit

Permalink
mlx4_core: fix bug in modify_cq wrapper for resize flow.
Browse files Browse the repository at this point in the history
The actual FW command is called in procedure "handle_resize".
Code incorrectly invoked the FW command again (in good flow), in
the modify_cq wrapper function.

Fix by skipping second FW invocation unconditionally for resize.

Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jack Morgenstein authored and davem330 committed Mar 8, 2012
1 parent 7831545 commit dcf353b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
Expand Up @@ -2255,8 +2255,7 @@ int mlx4_MODIFY_CQ_wrapper(struct mlx4_dev *dev, int slave,

if (vhcr->op_modifier == 0) {
err = handle_resize(dev, slave, vhcr, inbox, outbox, cmd, cq);
if (err)
goto ex_put;
goto ex_put;
}

err = mlx4_DMA_wrapper(dev, slave, vhcr, inbox, outbox, cmd);
Expand Down

0 comments on commit dcf353b

Please sign in to comment.