Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added login shell to bash #319

Merged
merged 1 commit into from Jul 31, 2015
Merged

added login shell to bash #319

merged 1 commit into from Jul 31, 2015

Conversation

scopatz
Copy link
Member

@scopatz scopatz commented Jul 26, 2015

This might help with #313

@scopatz scopatz added the bug label Jul 26, 2015
@scopatz scopatz added this to the v0.2 milestone Jul 26, 2015
@michaelaye
Copy link
Contributor

Getting this now:

klay6683@MacL2938 ~ $ aliases['cdsrc']
['cd', '$HOME/Dropbox/src']
klay6683@MacL2938 ~ $ cdsrc
cd: no such file or directory: $HOME/Dropbox/src

@scopatz
Copy link
Member Author

scopatz commented Jul 26, 2015

I think that you could fix this by changing the alias in bash to cd ~/Dropbox/src

@michaelaye
Copy link
Contributor

That's not a fix, that's a cheat. The user should not have to change her bash setup to make xonsh work.

@scopatz
Copy link
Member Author

scopatz commented Jul 30, 2015

hey @melund - would you mind taking a look at this PR and possibly merging it?

@melund
Copy link
Member

melund commented Jul 31, 2015

Hi @scopatz . I can't test it since I use Windows. However, reading up on bash, it seems reasonable. I can still click merge button if you want :)

The last issue raised by @michaelaye is another. I can't do that on windows either.
cd $USERPROFILE works fine. But cd $USERPROFILE/Documents does not. In the shell, it is not a problem. If I press 'tab' the autocompleter expands it to the full path. Should we create an separate issue for it?

@scopatz
Copy link
Member Author

scopatz commented Jul 31, 2015

I can still click merge button if you want :)

Please do!

Should we create an separate issue for it?

I think so. Thanks!

melund added a commit that referenced this pull request Jul 31, 2015
added login shell to bash
@melund melund merged commit 29b5da5 into master Jul 31, 2015
@melund
Copy link
Member

melund commented Jul 31, 2015

I have create a new issue for the problem reported by @michaelaye
#338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants