Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bash completions - Pass parsed command line to py-bash-commands #4219

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

daniel-shimon
Copy link
Contributor

This PR passes the parsed command line (the real arguments and quotes to use).
Generally, the following scenarios functioned badly until now:

ls '/pro<TAB>
# ls /proc/

ls '/pro<TAB>'
# ls /proc/'

ls './spa<TAB>'
# ls './spaced dir''

ls './spa'<TAB>
# the bash completer won't work at all

ls './spaced d<TAB>
# the bash completer won't work

A matching PR is open at xonsh/py-bash-completion#19

For community

⬇️ Please click the 👍 reaction instead of leaving a +1 or 👍 comment

@codecov-io
Copy link

Codecov Report

Merging #4219 (e5b71d7) into main (5a792a6) will increase coverage by 0.03%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4219      +/-   ##
==========================================
+ Coverage   52.88%   52.91%   +0.03%     
==========================================
  Files         129      129              
  Lines       20006    20019      +13     
  Branches     3604     3608       +4     
==========================================
+ Hits        10581    10594      +13     
  Misses       8548     8548              
  Partials      877      877              
Impacted Files Coverage Δ
xonsh/completers/bash.py 97.29% <95.00%> (-2.71%) ⬇️
xonsh/completers/bash_completion.py 30.25% <100.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a792a6...e5b71d7. Read the comment docs.

Copy link
Collaborator

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for this @daniel-shimon !

@gforsyth gforsyth merged commit 0ac7051 into xonsh:main Apr 12, 2021
@daniel-shimon daniel-shimon deleted the improve-bash-completions branch April 12, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants