Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ![] to return an object for background command #4823

Merged
merged 2 commits into from
Jun 5, 2022

Conversation

yaxollum
Copy link
Member

@yaxollum yaxollum commented May 27, 2022

Fixes #4595

Addresses #4406 (comment)

For community

⬇️ Please click the 👍 reaction instead of leaving a +1 or 👍 comment

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022

Codecov Report

Merging #4823 (925f7d5) into main (259fbe5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4823      +/-   ##
==========================================
+ Coverage   66.62%   66.64%   +0.01%     
==========================================
  Files         134      134              
  Lines       23558    23559       +1     
  Branches     4672     4673       +1     
==========================================
+ Hits        15695    15700       +5     
+ Misses       6644     6643       -1     
+ Partials     1219     1216       -3     
Flag Coverage Δ
macOS-latest 63.64% <100.00%> (+0.06%) ⬆️
ubuntu-latest 64.23% <100.00%> (+0.03%) ⬆️
windows-latest 62.57% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xonsh/procs/pipelines.py 81.48% <100.00%> (-0.78%) ⬇️
xonsh/procs/specs.py 73.22% <100.00%> (+0.04%) ⬆️
xonsh/parsers/base.py 85.18% <0.00%> (+0.12%) ⬆️
xonsh/procs/posix.py 71.25% <0.00%> (+0.62%) ⬆️
xonsh/jobs.py 45.89% <0.00%> (+1.36%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Fixes xonsh#4595

This issue was caused by `CommandPipeline.term_pgid` not being set for commands started in the background.
@jnoortheen jnoortheen merged commit be604e7 into xonsh:main Jun 5, 2022
@jnoortheen
Copy link
Member

Thanks @yaxollum

@yaxollum yaxollum deleted the backgrounding-return-hiddenobject branch July 30, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jobs fg: on ctrl+c, shell returns to prompt but task is still running on background
3 participants