Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An AggregateFileSystem in an AggregateFileSystem stomps in TryGetPath #64

Closed
garrynewman opened this issue Feb 1, 2022 · 2 comments
Closed
Labels

Comments

@garrynewman
Copy link
Contributor

In TryGetPath we just return here

if (fileSystem is AggregateFileSystem aggregate)
{
return aggregate.TryGetPath(path, searchTarget);
}

But we should really only be returning if the path it returns is valid, since it isn't giving the other systems a chance to check for the file.

@xoofx xoofx added the bug label Feb 1, 2022
@xoofx
Copy link
Owner

xoofx commented Feb 1, 2022

Yep, agreed

@xoofx
Copy link
Owner

xoofx commented Feb 4, 2022

Fixed by commit 8a42485

@xoofx xoofx closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants