New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: implement sklearn.model_selection.ParameterGrid
#421
Conversation
Codecov Report
@@ Coverage Diff @@
## main #421 +/- ##
==========================================
- Coverage 93.61% 86.88% -6.74%
==========================================
Files 991 992 +1
Lines 76729 76773 +44
Branches 15955 15970 +15
==========================================
- Hits 71830 66703 -5127
- Misses 3278 8222 +4944
- Partials 1621 1848 +227
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, left two questions.
…into parameter-grid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
python/xorbits/_mars/learn/model_selection/tests/test_search.py
Outdated
Show resolved
Hide resolved
Signed-off-by: RandomY-2 <69881587+RandomY-2@users.noreply.github.com>
Signed-off-by: RandomY-2 <69881587+RandomY-2@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution :)
What do these changes do?
Related issue number
Fixes #xxxx
Check code requirements