Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: implement sklearn.model_selection.ParameterGrid #421

Merged
merged 15 commits into from May 9, 2023

Conversation

RandomY-2
Copy link
Contributor

@RandomY-2 RandomY-2 commented Apr 29, 2023

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.3.0 milestone Apr 29, 2023
@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Merging #421 (5966f12) into main (6cad4b0) will decrease coverage by 6.74%.
The diff coverage is 97.72%.

@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
- Coverage   93.61%   86.88%   -6.74%     
==========================================
  Files         991      992       +1     
  Lines       76729    76773      +44     
  Branches    15955    15970      +15     
==========================================
- Hits        71830    66703    -5127     
- Misses       3278     8222    +4944     
- Partials     1621     1848     +227     
Flag Coverage Δ
unittests 86.77% <97.72%> (-6.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hon/xorbits/_mars/learn/model_selection/_search.py 97.67% <97.67%> (ø)
...on/xorbits/_mars/learn/model_selection/__init__.py 100.00% <100.00%> (ø)

... and 280 files with indirect coverage changes

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, left two questions.

@XprobeBot XprobeBot modified the milestones: v0.3.0, v0.3.1 May 6, 2023
aresnow1
aresnow1 previously approved these changes May 8, 2023
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: RandomY-2 <69881587+RandomY-2@users.noreply.github.com>
Signed-off-by: RandomY-2 <69881587+RandomY-2@users.noreply.github.com>
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@UranusSeven UranusSeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution :)

@UranusSeven UranusSeven merged commit 039503b into xorbitsai:main May 9, 2023
27 of 28 checks passed
@RandomY-2 RandomY-2 deleted the parameter-grid branch May 12, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants