Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: Compatible with Arrow 12.0.0 #426

Merged
merged 6 commits into from May 8, 2023
Merged

Conversation

aresnow1
Copy link
Contributor

@aresnow1 aresnow1 commented May 5, 2023

What do these changes do?

Compatible with Arrow 12.0.0, mainly for deprecated plasma.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.3.0 milestone May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #426 (3c5432b) into main (c2d8cdd) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   93.66%   93.56%   -0.10%     
==========================================
  Files         988      988              
  Lines       76147    76141       -6     
  Branches    15887    15885       -2     
==========================================
- Hits        71325    71244      -81     
- Misses       3231     3278      +47     
- Partials     1591     1619      +28     
Flag Coverage Δ
unittests 93.46% <50.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xorbits/_mars/services/storage/api/oscar.py 100.00% <100.00%> (+3.57%) ⬆️
python/xorbits/_mars/storage/plasma.py 95.18% <100.00%> (-1.21%) ⬇️

... and 24 files with indirect coverage changes

@aresnow1 aresnow1 marked this pull request as ready for review May 6, 2023 04:16
@XprobeBot XprobeBot modified the milestones: v0.3.0, v0.3.1 May 6, 2023
qianduoduo0904
qianduoduo0904 previously approved these changes May 7, 2023
Copy link
Contributor

@qianduoduo0904 qianduoduo0904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qianduoduo0904 qianduoduo0904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit f483d1e into xorbitsai:main May 8, 2023
29 checks passed
@aresnow1 aresnow1 deleted the chore/plasma branch May 8, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants