Explicitly link with -no-pie
#9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If libcapstone.a is not build with `-fPIC`, building `injector` fails with the error below. ``` /usr/bin/ld: injector.o: relocation R_X86_64_32S against undefined symbol `dummy_stack' can not be used when making a shared object; recompile with -fPIC ``` So explicitly link the binary as a position dependent executable by passing `-no-pie` [1]. This probably needs to be made configurable, or the build system needs to detect how `libcapstone.a` is built. [1] https://wiki.ubuntu.com/SecurityTeam/PIE Fixes: xoreaxeaxeax#2, xoreaxeaxeax#5
|
Trying to run the Python script afterward results in the error below. No idea if it’s related to the Debian platform or this change. |
igalic
reviewed
Aug 16, 2017
| @@ -32,7 +32,7 @@ | |||
| all: injector | |||
|
|
|||
| injector: injector.o | |||
| $(CC) $(CFLAGS) $< -O3 -Wall -l:libcapstone.a -o $@ -pthread | |||
| $(CC) $(CFLAGS) $< -O3 -Wall -no-pie -l:libcapstone.a -o $@ -pthread | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Debian Sid/unstable with Debian’s package
libcapstone-dev 3.0.4-1 installed.