MQTT Will message is invalid

[xoseperez]

Originally reported by: Abílio Costa (Bitbucket: amfcosta, GitHub: Unknown)

---

The MQTT will message is not correct. It seems to be reading another memory part.

After looking at the code, I think the issue is here (haven't tested yet): https://bitbucket.org/xoseperez/espurna/src/e327a219a81af889d81701e94f41eb78ec5db426/code/espurna/mqtt.ino?at=master&fileviewer=file-view-default#mqtt.ino-251

On line 251, the will char* is being freed, but it is probably stored by the mqtt lib when mqtt.setWill(...) is called.

[xoseperez]

For me it is working fine, I get the will topic ~40 seconds after disconnecting the board...

[xoseperez]

Original comment by Abílio Costa (Bitbucket: amfcosta, GitHub: Unknown):

---

Weird. The device on which you tested was being used? Try to toggle its state sometimes before disconnecting, just to try and get that memory zone rewritten. Could it be that when you tested, despite being freed, the memory still had the valid contents?

This is what I'm getting from mosquitto_sub:

#!arduino

Client mosqsub/2342-rpi3 received PUBLISH (d0, q0, r0, m0, 'yGetter', ... (1 bytes))
0

The topics vary a bit ("yGetter", "1Getter", "Getter"), that's why it looks like invalid memory reads.

Tested on a Sonoff S20 and a Sonoff TH10.

[xoseperez]

Caught it! Moved the variable to global scope. Right now in the dev branch, will be released soon.

[xoseperez]

Original comment by Abílio Costa (Bitbucket: amfcosta, GitHub: Unknown):

---

Great! :D

[xoseperez]

Pushed with 1.8.3.

[xoseperez]

Removing milestone: 1.8.3 (automated comment)