Fauxmoesp preprocessor flag naming conflict

[xoseperez]

Originally reported by: Neg kel (Bitbucket: Negativekelvin0, GitHub: Unknown)

---

Should be ENABLE_FAUXMO

https://bitbucket.org/xoseperez/espurna/src/b4e04f24be64bcf37fb2cbec7c3afd8bfeda8237/code/src/config/general.h?at=master&fileviewer=file-view-default#general.h-102

Also instructions at bottom of this page: http://tinkerman.cat/emulate-wemo-device-esp8266/

Must have confused it with the internal property name: https://bitbucket.org/xoseperez/espurna/src/b4e04f24be64bcf37fb2cbec7c3afd8bfeda8237/code/src/fauxmo.ino?at=master&fileviewer=file-view-default#fauxmo.ino-21

[xoseperez]

ENABLE_FAUXMO and FAUXMO_ENABLED are different things. The first on is a compile flag that indicates weather the firmware has to include fauxmo support or not. The second is a default value for the setting that indicates if the device should respond to Alexa requests. So you can have support on the firmware but have it disabled cause you actually don't need it in a certain device.
The code is OK but the you are right that the post is wrong. I'm changing it.
I understand the confusion since the names are so similar. I'm going to change the second one to something more understandable, maybe FAUXMO_DISCOVERABLE?

[xoseperez]

Original comment by Neg kel (Bitbucket: Negativekelvin0, GitHub: Unknown):

---

Oh OK i see you're right the only problem was the blog post and lack of documentation on build flag options. Not sure about the naming but maybe it would be good to prefix them with SETTINGS_ and/or DEFAULT. Thanks.

[xoseperez]

You are so right. There is a lack of documentation and I'm working on it.

[xoseperez]

Inline documentation improved in version 1.5.0