Hostname advertised to DHCP is truncated at 20 characters

[wsw70]

A hostname defined as chambre1-lampe_bureau on ESPurna is registered by my DHCP as chambre1-lampe_burea (the last u is missing).

ESPurna apparently cuts the advertised hostname at 20 characters: below is a tcpdump of the DHCP Request from the device to the DHCP server:

Is there a particular reason for this? (the DHCP server can handle longer hostnames, I see all kind of android-97d6cbda92c6fgb56 kind of entries).

The only place where I see this cutoff is in DHCP, in other places (web interface, MQTT telemetry data) the hostname is complete.

[mcspr]

Yep, thats a bug. Limit should be 32 because hostname is linked to SSID.

20 limit comes from justwifi
From espurna side 847e1e6 can be reverted and adapted to the new limit.

[Skaronator]

20 limit comes from justwifi

Take a look who wrote this code. :P It is probably better to increase this to 30 or 40 chars than reverting 847e1e6

[mcspr]

@Skaronator What I mean is - it is not possible to go outside 32 with current setup. Access point SSID cannot be longer than that.

Underlying arduino methods already have the limit check for STA hostname and AP SSID (even better - 31 chars :/) so required justwifi change should probably be as easy as changing buffer length. AP must still work even truncated. WebUI though should enforce the limit.

[xoseperez]

Staged for release. Closing.

[wsw70]

Confirmed that the name is not truncated anymore. Thanks.