Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SERIAL_SENSOR support (#2477) #2478

Merged
merged 4 commits into from
Oct 12, 2021
Merged

Add SERIAL_SENSOR support (#2477) #2478

merged 4 commits into from
Oct 12, 2021

Conversation

pbek
Copy link
Contributor

@pbek pbek commented Oct 3, 2021

Implements #2477

@pbek pbek mentioned this pull request Oct 3, 2021
Closed
mcspr
mcspr reviewed Oct 3, 2021
View reviewed changes
code/espurna/serialsensor.cpp Outdated Show resolved Hide resolved
mcspr
mcspr reviewed Oct 3, 2021
View reviewed changes
code/espurna/serialsensor.cpp Outdated Show resolved Hide resolved
@mcspr mcspr merged commit 51133a6 into xoseperez:dev Oct 12, 2021
@mcspr
Copy link
Collaborator

mcspr commented Oct 12, 2021

Sorry for the delay :)
I have tried to use Codespaces to fixup based on my last comment, but it failed to push to the writable PR branch... So that involved some manual git manipulations with a proper PC.

I moved the func to the mqtt.cpp, so no need for the extra -DSERIAL_SENSOR_SUPPORT=1 and it just works when MQTT is enabled.

@pbek
Copy link
Contributor Author

pbek commented Oct 12, 2021

Great too, thank you very much! 😁

@pbek pbek deleted the feature/serial-sensor branch October 12, 2021 17:18
peterhoeg pushed a commit to peterhoeg/espurna that referenced this pull request Nov 21, 2021
@pbek @mcspr @peterhoeg
mqtt: add mqtt.send terminal command (xoseperez#2477) (xoseperez#2478)
d1e29d4 
* Add SERIAL_SENSOR support

* Implement "MQTT.SEND" command, remove all other commands (xoseperez#2477)

* Move command to mqtt.cpp and drop extra files

* Update CHANGELOG.md

Co-authored-by: Max Prokhorov <prokhorov.max@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcspr mcspr mcspr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbek @mcspr