Add undo action for selection moved with keyboard

src/core/control/tools/EditSelection.cpp

@@ -753,14 +753,18 @@ void EditSelection::updateMatrix() {
     cairo_matrix_translate(&this->cmatrix, -rx, -ry);
 }
 
-void EditSelection::moveSelection(double dx, double dy) {
+void EditSelection::moveSelection(double dx, double dy, bool addMoveUndo) {
     this->x += dx;
     this->y += dy;
     this->snappedBounds.x += dx;
     this->snappedBounds.y += dy;
 
     updateMatrix();
 
+    if (addMoveUndo) {
+        this->contents->addMoveUndo(this->undo, dx, dy);
+    }
+
     this->view->getXournal()->repaintSelection();
 }
 

src/core/control/tools/EditSelection.h

@@ -220,7 +220,7 @@ class EditSelection: public ElementContainer, public Serializable {
     /**
      * Move the selection
      */
-    void moveSelection(double dx, double dy);
+    void moveSelection(double dx, double dy, bool addMoveUndo = false);
 
     /**
      * Get the cursor type for the current position (if 0 then the default cursor should be used)

src/core/control/tools/EditSelectionContents.cpp

@@ -82,6 +82,15 @@ void EditSelectionContents::replaceInsertOrder(std::deque<std::pair<Element*, El
     this->insertOrder = std::move(newInsertOrder);
 }
 
+void EditSelectionContents::addMoveUndo(UndoRedoHandler* undo, double dx, double dy) {
+    undo->addUndoAction(std::make_unique<MoveUndoAction>(this->sourceLayer, this->sourcePage, &this->selected, dx, dy,
+                                                         this->sourceLayer, this->sourcePage));
+    this->lastBounds.x += dx;
+    this->lastBounds.y += dy;
+    this->lastSnappedBounds.x += dx;
+    this->lastSnappedBounds.y += dy;
+}
+
 /**
  * Returns all containing elements of this selection
  */

src/core/control/tools/EditSelectionContents.h

@@ -104,6 +104,8 @@ class EditSelectionContents: public ElementContainer, public Serializable {
      * */
     void replaceInsertOrder(std::deque<std::pair<Element*, Element::Index>> newInsertOrder);
 
+    void addMoveUndo(UndoRedoHandler* undo, double dx, double dy);
+
 public:
     /**
      * paints the selection

src/core/gui/XournalView.cpp

@@ -169,7 +169,7 @@ auto XournalView::onKeyPressEvent(GdkEventKey* event) -> bool {
             ydir = 1;
         }
         if (xdir != 0 || ydir != 0) {
-            selection->moveSelection(d * xdir, d * ydir);
+            selection->moveSelection(d * xdir, d * ydir, true);
             selection->ensureWithinVisibleArea();
             return true;
         }