Sink floating widget ref in Preview Entries - fix SegFault

xournalpp · Aug 28, 2023 · 5c35246 · 5c35246
1 parent a9f46a1
commit 5c35246
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/core/gui/sidebar/previews/base/SidebarPreviewBaseEntry.cpp b/src/core/gui/sidebar/previews/base/SidebarPreviewBaseEntry.cpp
@@ -17,10 +17,8 @@
 
 SidebarPreviewBaseEntry::SidebarPreviewBaseEntry(SidebarPreviewBase* sidebar, const PageRef& page):
         sidebar(sidebar), page(page) {
-    this->widget = gtk_button_new();  // re: issue 1072
-
+    this->widget = GTK_WIDGET(g_object_ref_sink(gtk_button_new()));
     gtk_widget_show(this->widget);
-    g_object_ref(this->widget);
 
     updateSize();
     gtk_widget_set_events(widget, GDK_EXPOSURE_MASK);

diff --git a/src/core/gui/sidebar/previews/layer/SidebarPreviewLayerEntry.cpp b/src/core/gui/sidebar/previews/layer/SidebarPreviewLayerEntry.cpp
@@ -15,9 +15,8 @@ SidebarPreviewLayerEntry::SidebarPreviewLayerEntry(SidebarPreviewLayers* sidebar
         sidebar(sidebar),
         index(index),
         layerId(layerId),
-        box(gtk_box_new(GTK_ORIENTATION_VERTICAL, 2)),
+        box(GTK_WIDGET(g_object_ref_sink(gtk_box_new(GTK_ORIENTATION_VERTICAL, 2)))),
         stacked(stacked) {
-
     const auto clickCallback = G_CALLBACK(+[](GtkWidget* widget, GdkEvent* event, SidebarPreviewLayerEntry* self) {
         // Open context menu on right mouse click
         if (event->type == GDK_BUTTON_PRESS) {